New issue
Advanced search Search tips

Issue 792421 link

Starred by 1 user
Status: Fixed
Owner:
pasko@chromium.org
Closed: Dec 2017
Cc:
perezju@chromium.org
lizeb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

orderfile-clankium consistently failing

Project Member Reported by alexilin@chromium.org, Dec 6 2017 
6 latest builds have failed on "Generate Orderfile" step:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium

Example of a failing build:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium/builds/6809

INFO:root:Try printing formatted exception: <type 'exceptions.TypeError'> unhashable type <traceback object at 0x7fc5763d2680>
Traceback (most recent call last):
  <module> at /b/build/slave/orderfile-clankium/build/src/clank/tools/orderfile_generator.py:62
    sys.exit(main(sys.argv))
  main at /b/build/slave/orderfile-clankium/build/src/clank/tools/orderfile_generator.py:58
    options, OrderfileUpdater) else 1)
  CreateOrderfile at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/orderfile_generator_backend.py:807
    return generator.Generate()
  Generate at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/orderfile_generator_backend.py:696
    self._GenerateAndProcessProfile()
  _GenerateAndProcessProfile at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/orderfile_generator_backend.py:525
    constants.PACKAGE_INFO['chrome'])
  CollectProfile at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/profile_android_startup.py:234
    package_info.cmdline_file, package_info.package):
  __enter__ at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/profile_android_startup.py:94
    self.Start()
  Start at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/profile_android_startup.py:85
    self._BringUpWpr()
  _BringUpWpr at /b/build/slave/orderfile-clankium/build/src/tools/cygprofile/profile_android_startup.py:107
    ports = self._wpr_server.StartServer()[:-1]
TypeError: unhashable type
Locals:
  No locals!
step returned non-zero exit code: 1

Comment 1 by pasko@chromium.org, Dec 6 2017

Cc: -pasko@chromium.org perezju@chromium.org
Owner: pasko@chromium.org
Seems to be from this roll of catapult: https://chromium-review.googlesource.com/808127 which brings in this change: https://chromium-review.googlesource.com/c/catapult/+/796863

We can just fix it on the orderfile side without stopping autoroll and all this difficulty. Let me look closer.

Comment 2 by perezju@chromium.org, Dec 6 2017 

Yep! Sorry about that. Somehow I didn't find your client when making the API change.

It should just be a matter of replacing:

  ports = self._wpr_server.StartServer()[:-1]

with e.g.

  wpr_ports = self._wpr_server.StartServer()
  ports = (wpr_ports['http'], wpr_ports['https'])

Comment 3 by pasko@chromium.org, Dec 6 2017

Labels: sheriff-android
In review: https://chromium-review.googlesource.com/c/chromium/src/+/810967
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfe5f786ce4435d01a78f3cf33248bef9b743732

commit bfe5f786ce4435d01a78f3cf33248bef9b743732
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Dec 06 15:03:29 2017

Update profile_android_startup.py for catapult API change

Update to the new way of getting the HTTP and HTTPS ports for the
WebPageReplay server, which was introduced in:
https://chromium-review.googlesource.com/c/catapult/+/796863

Bug:  792421 
Change-Id: I62b8b18043aff03781fcfba2ac63eaf0e5921b28
Reviewed-on: https://chromium-review.googlesource.com/810967
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522086}
[modify] https://crrev.com/bfe5f786ce4435d01a78f3cf33248bef9b743732/tools/cygprofile/profile_android_startup.py

Comment 5 by pasko@chromium.org, Dec 7 2017

Status: Fixed (was: Available)
The bot is green. Thank you for quick suggestion, Juan, it saved me from hours of testing :)

Comment 6 by perezju@chromium.org, Dec 7 2017 

No prob! Sorry I broke it in the first place. :-P
►

Sign in to add a comment