Issue metadata
Sign in to add a comment
|
Regression : Blue Highlight Bubble is seen misplaced in Sign-out screen |
||||||||||||||||||||||||
Issue descriptionChrome Version: 64.0. 3282.7/10176.4.0 Candy, Paine & Gnawty OS: Chrome What steps will reproduce the problem? (1)Sign into User -> At Uber Tray click on 'Sign out' (2)Now in Sign-out screen at uber Tray select 'Accessibility' ->Select 'Highlight text caret' option -> observe Blue Highlight Bubble is seen misplaced i.e. Blue Highlight Bubble is seen at top L.H.S of the screen (Please refer Video and Screenshot) Expected: Blue Highlight Bubble should be seen where cursor is available and (here in sign-out screen for one user cursor is seen at 'Password' field and Blue Highlight Bubble should be seen at 'Password' field) Actual: Instead Blue Highlight Bubble is seen misplaced i.e. Blue Highlight Bubble is seen at top L.H.S of the screen This is Regression Issue as same is working fine in M-63 @dmazzoni : Please confirm the issue
,
Dec 6 2017
Attaching Expected video and screenshot for reference
,
Dec 6 2017
,
Dec 6 2017
I can repro, but I can't confirm that it was working correctly in 63. I see the same bad behavior in 62, 63, 64, and canary. I was able to bisect this, and the regression range matches, it regressed in 62: You are probably looking for a change made after 491450 (known good), but no later than 491457 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a554e3a7c070e2648eb62dc2f6a1aa939525ef9f..eb1ae2189f5021763cb8d82bf05df1b371582c5b
,
Dec 6 2017
Unfortunately the problem doesn't go away if I revert any of the changes in that revision range. Assigning back to mmanchala to try to confirm the range, that translates to 62.0.3174.0 being good and 62.0.3175.0 being bad.
,
Dec 8 2017
C#5> 1.Issue is seen on M-63 i.e. on 63.0.3239.86/10032.71.0 beta-channel 2.Issue is working fine in 62.0.3202.101/9901.79.0 stable-channel Candy
,
Dec 12 2017
@yhanada or @shuchen, could you take a look? The caret highlighting code is implemented in chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc - the class is a ui::InputMethodObserver, and most of the work is done in OnCaretBoundsChanged. What I observe is that since r491457, if you follow the repro instructions and enable "Highlight text caret" on the first login screen, the highlight is in the upper left of the screen. I checked the code and OnCaretBoundsChanged is being called with incorrect bounds and state information that doesn't match where the text caret really is. Note that you can repro locally without a Chromebook, just build with target_os="chromeos" and then run with a fresh profile and --login-manager. (OK to remove release block, I think it's worth looking into why this regressed, but it's cosmetic and I don't think it warrants blocking release)
,
Dec 18 2017
Thank you for your detailed investigation. I'll take a look at this.
,
Dec 19 2017
It seems that a child frame of the login ui takes focus from the main frame and it claims the cursor position is top-left. +owners of login page, do you have any ideas about this behavior?
,
Jan 4 2018
Removing stable block since this has been going on for a while.
,
May 7 2018
,
May 31 2018
Is this still a problem? I was not able to repro when I tried it today.
,
May 31 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 Deleted