New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make Files app compatible with native FSP providers.

Project Member Reported by mtomasz@chromium.org, Dec 6 2017

Issue description

C++ side is mostly done, but JS not yet.
 
Components: Internals>Cast>FileManager
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f631ba671168bed80ec1aa3fd3fb8f60ab07083e

commit f631ba671168bed80ec1aa3fd3fb8f60ab07083e
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Fri Dec 08 07:03:37 2017

Generalize ProvidingExtension to Provider.

From now on FSP file systems can be backed by native implementation.
So, for those there is no extension_id.

C++ side is already migrated, but this CL updates the JS side.

Tbr: isherman
Bug:  792414 
Test: All compiles.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice5b1c7d8ab1567405f93e8d9d0aff48dda66f35
Reviewed-on: https://chromium-review.googlesource.com/810704
Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522729}
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/test/data/extensions/api_test/file_browser/mount_test/test.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/test/data/extensions/api_test/file_system_provider/configure/test.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/chrome/test/data/extensions/api_test/file_system_provider/mount/test.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/externs/volume_info.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/common/js/metrics_events.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/foreground/js/providers_model.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/foreground/js/providers_model_unittest.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/foreground/js/ui/providers_menu.js
[modify] https://crrev.com/f631ba671168bed80ec1aa3fd3fb8f60ab07083e/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

Status: Fixed (was: Started)

Sign in to add a comment