Regression:Tab content is not aligned properly.
Reported by
shruti.j...@etouch.net,
Dec 6 2017
|
||||||||||||
Issue descriptionChrome Version:65.0.3286.0 (Official Build)7f87a643cf9d5de271f2b6adeb7e30d6a5f8eb5d-refs/heads/master@{#521956} (64-bit) OS: Win(7,8,10), Mac(10.12.6,10.13.1) and Linux(14.04 LTS). Test-URL:https://www.google.co.in/intl/en/policies/terms/regional.html Steps to reproduce: 1.Launch chrome and Navigate to above URL. 2.Navigate to every Tab Index and observe each page under Tab index. Actual Result: Tab content is not aligned properly. Expected Result:Tab content should be aligned properly. This is regression issue broken in ‘M-64’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 64.0.3278.0(Revision:519170 ). Bad Build: 64.0.3279.0(Revision:519518). You are probably looking for a change made after 519294 (known good), but no lat er than 519295 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/16b74ca517cbf521cfddd48487 15842765345b84..316e035cd2bff593e99410ee786b0e956a89d1d2 Suspect:https://chromium.googlesource.com/chromium/src/+/316e035cd2bff593e99410ee786b0e956a89d1d2 @edwardjung: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Dec 6 2017
https://chromium.googlesource.com/chromium/src/+/722937f7116a2c448d0700b6d90318852369c785 Mike, I think this is due to your change. I see maya.experimental.css being blocked in DevTools (need to turn the caching back on).
,
Dec 7 2017
,
Dec 7 2017
Thanks dglazkov@, that was super helpful! It looks like the page is returning a 304 response with an `x-content-type-options: nosniff` header and no `content-type`. Uploaded https://chromium-review.googlesource.com/#/c/chromium/src/+/813835 to address, and we'll need to merge it back to M64. Sorry about that bug!
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a66ae460a9609d687bff9c83d55fb9d89c5d48b3 commit a66ae460a9609d687bff9c83d55fb9d89c5d48b3 Author: Mike West <mkwst@chromium.org> Date: Mon Dec 11 10:04:36 2017 Check `nosniff` on the original response, not revalidation responses. Bug: 792412 Change-Id: Id805387dea88e18e71d21ca1e799d1076d0b2c5e Reviewed-on: https://chromium-review.googlesource.com/813835 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523068} [modify] https://crrev.com/a66ae460a9609d687bff9c83d55fb9d89c5d48b3/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/resources/css.py [modify] https://crrev.com/a66ae460a9609d687bff9c83d55fb9d89c5d48b3/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/stylesheet.html [modify] https://crrev.com/a66ae460a9609d687bff9c83d55fb9d89c5d48b3/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
,
Jan 3 2018
Update : Retested above issue on Mac(10.12.6, 10.13.2), Windows(7,8,10) and Linux(14.04 LTS) OS using latest Canary #65.0.3309.0 and issue is working as intended and fixed.Tab contents are aligned properly. Thank you!
,
Jan 6 2018
Hello, lovely release managers. This was mislabeled as 65, but appears to affect 64. I'd like to merge the fix back; it's had plenty of time to bake on 65, and is fairly minor to begin with. WDYT?
,
Jan 6 2018
Issue 796471 has been merged into this issue.
,
Jan 6 2018
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 8 2018
,
Jan 8 2018
+ Abdul & Estelle for M64 merge review.
,
Jan 9 2018
,
Jan 9 2018
Please merge this today
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5476496b3f527a0377e8db4e00d8e5783f3a9400 commit 5476496b3f527a0377e8db4e00d8e5783f3a9400 Author: Mike West <mkwst@chromium.org> Date: Tue Jan 09 22:45:21 2018 Check `nosniff` on the original response, not revalidation responses. TBR=mkwst@chromium.org (cherry picked from commit a66ae460a9609d687bff9c83d55fb9d89c5d48b3) Bug: 792412 Change-Id: Id805387dea88e18e71d21ca1e799d1076d0b2c5e Reviewed-on: https://chromium-review.googlesource.com/813835 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523068} Reviewed-on: https://chromium-review.googlesource.com/858140 Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#471} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/5476496b3f527a0377e8db4e00d8e5783f3a9400/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/resources/css.py [modify] https://crrev.com/5476496b3f527a0377e8db4e00d8e5783f3a9400/third_party/WebKit/LayoutTests/external/wpt/fetch/nosniff/stylesheet.html [modify] https://crrev.com/5476496b3f527a0377e8db4e00d8e5783f3a9400/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
,
Jan 10 2018
,
Jan 10 2018
Android: Works as per expected behavior, Issue verified on M65: 65.0.3316.0 and M64: 64.0.3282.85 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by msrchandra@chromium.org
, Dec 6 2017