New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792401 link

Starred by 4 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Dec 2017
Cc:
ajha@chromium.org
pnangunoori@chromium.org
nyerramilli@chromium.org
█ brajkumar@chromium.org
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Omnibox is seen blank when page is getting loaded

Project Member Reported by kebalaji@chromium.org, Dec 6 2017 
Chrome Version: 65.0.3286.0  dev
OS: Windows

What steps will reproduce the problem?
(1)Launch chrome>> In omnibox, type something(Eg: Flipkart.in) and observe

Actual: While page is loading, omnibox is seen blank
Expected: Omnibox should not be seen blank

This is a Regression issue seen from M65

Will update other info soon

Comment 1 by kebalaji@chromium.org, Dec 6 2017

Labels: hasbisect-per-revision M-65 ReleaseBlock-Beta OS-Linux OS-Mac
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Information:
------------------
Good Build:65.0.3284.0
Bad Build: 65.0.3285.0

You are probably looking for a change made after 521358 (known good), but no later than 521359 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/80fcc0006f18421ea22bc3ba0d35a0cddf3dea1d..cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8

Suspecting https://chromium.googlesource.com/chromium/src/+/cb3d859ad53f667a8cca5cb5d18ed09b13c51ef8 from above CL

@treib: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
ActualOmnibox.webm
2.5 MB View Download
ExpectedOmnibox.webm
2.9 MB View Download

Comment 2 by treib@chromium.org, Dec 6 2017

Components: UI>Browser>NewTabPage
Labels: OS-Chrome
Yup, that's probably the correct culprit. I'll look into it.

Comment 3 by treib@chromium.org, Dec 6 2017

Status: Started (was: Assigned)

Comment 5 by mvanouwe...@chromium.org, Dec 6 2017

Labels: zine-triaged
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7b2505fb9ce94903583bd41f7fd4e97f21cc7de

commit c7b2505fb9ce94903583bd41f7fd4e97f21cc7de
Author: Marc Treib <treib@chromium.org>
Date: Thu Dec 07 12:20:11 2017

Omnibox: Show visible URL while navigating away from NTP

This was broken recently by crrev.com/c/800931.

Bug:  792401 
Change-Id: Idd269b49bd282a7faa6ca13a259f60384b2b5a08
Reviewed-on: https://chromium-review.googlesource.com/810788
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522404}
[modify] https://crrev.com/c7b2505fb9ce94903583bd41f7fd4e97f21cc7de/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/c7b2505fb9ce94903583bd41f7fd4e97f21cc7de/chrome/browser/ui/toolbar/toolbar_model_unittest.cc
[modify] https://crrev.com/c7b2505fb9ce94903583bd41f7fd4e97f21cc7de/components/omnibox/browser/omnibox_client.h

Comment 7 by treib@chromium.org, Dec 7 2017

Status: Fixed (was: Started)

Comment 8 by tapted@chromium.org, Dec 8 2017

Cc: treib@chromium.org
 Issue 792596  has been merged into this issue.

Comment 9 by pnangunoori@chromium.org, Dec 8 2017

Cc: nyerramilli@chromium.org pnangunoori@chromium.org
 Issue 793205  has been merged into this issue.
►

Sign in to add a comment