New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792373 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 603386



Sign in to add a comment

MacViews: ScrollBar thumbs should highlight when hovering anywhere over the entire track -- not just the thumb.

Reported by avsha...@etouch.net, Dec 6 2017

Issue description

Chrome Version : 65.0.3286.0 (Official Build) 7f87a643cf9d5de271f2b6adeb7e30d6a5f8eb5d-refs/heads/master@{#521956} 64-bit
OS : Mac(10.12.6) (10.13.2)

What steps will reproduce the problem?
1. Launch chrome, open NTP, click on ‘Bookmark..’ (Star) icon and click ‘Edit’ button in bookmark bubble (Edit Bookmark overlay appears).
2. Keep adding ‘New Folders’ until vertical & horizontal scrollbars appear in ‘Edit Bookmark’ overlay.
3. Now hover beside (and not over) the horizontal scrollbar and observe the scrollbar. (Kindly review an attached screen cast)

Actual Result : Scrollbar does not get activated while hovering beside it.

Expected Result : Scrollbar should get activated (i.e scrollbar should appear focused) when hovering beside it.

This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results,
Good build : 64.0.3260.0 (Revision : 514067)
Bad build : 64.0.3261.0 (Revision : 514329)

You are probably looking for a change made after 514116 (known good), but no later than 514117 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/04f1082efb63369e19ace6dde8b62c8702303b88..6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e

Suspect : https://chromium.googlesource.com/chromium/src/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e

@tapted : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : This is Mac OS specific issue.
 
Actual_Scrollbar.mov
4.6 MB Download
Expected_Scrollbar.mov
3.8 MB Download
Blocking: 603386
Cc: spqc...@chromium.org
Labels: -Pri-1 -M-64 M-65 Proj-HarmonyDialogs Proj-MacViews Pri-2
Summary: MacViews: ScrollBar thumbs should highlight when hovering anywhere over the entire track -- not just the thumb. (was: Regression : In 'Edit Bookmark' dialog, scrollbar does not get activated while hovering beside it.)
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Status: Started (was: Assigned)
Just to update:

Still seeing the same issue on Mac 10.12.6 using chrome latest Canary#65.0.3309.0.
tapted@/ spqchan@ , please take a look into this issue as it is marked as stable blocker.

Thanks..!
Friendly ping to get an update on this issue.
Thanks..!
Cc: -spqc...@chromium.org tapted@chromium.org
Owner: spqc...@chromium.org
Still working on it
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3c6f21f36d71161566f1b9a6b108b3467b7ce11

commit e3c6f21f36d71161566f1b9a6b108b3467b7ce11
Author: spqchan <spqchan@chromium.org>
Date: Wed Jan 10 21:38:11 2018

[MacViews] Fix Cocoa Scrollbar Thumb Highlight

The Cocoa legacy style scrollbar thumb should highlight
when the scrollbar track is highlighted.

Bug:  792373 
Change-Id: Ie64818ded49e8391dbc61c93e66fe67ca85fdcb7
Reviewed-on: https://chromium-review.googlesource.com/858418
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528432}
[modify] https://crrev.com/e3c6f21f36d71161566f1b9a6b108b3467b7ce11/ui/views/controls/scrollbar/cocoa_scroll_bar.mm

Comment 8 by avsha...@etouch.net, Jan 11 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3318.0
Update : 
Verified this issue on Mac(10.12.6), (10.13.1) & (10.13.3) OS with latest Canary build #65.0.3318.0 and the issue is fixed. Now, ScrollBar thumbs highlight when hovering over the track in ‘Edit bookmarks’ overlay. Kindly review an attached screen-cast.

Thank you!
Canary_behavior.mov
4.2 MB Download
Status: Fixed (was: Started)

Sign in to add a comment