Regression: [DevTools]Focus issue is observed on ColorPicker window.
Reported by
dchau...@etouch.net,
Dec 6 2017
|
||
Issue descriptionChrome Version: 65.0.3286.0 (Official Build) 7f87a643cf9d5de271f2b6adeb7e30d6a5f8eb5d-refs/heads/master@{#521956} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3). What steps will reproduce the problem? 1. Launch chrome, open DevTools and click to open ColorPicker window under Style section. 2. Click on second bidirectional arrow to open 'Color Palettes'. 3. Now once press 'Tab' key from keyboard and observe. Grey focus highlight doesn't seen on 'Return to color picker' (X) icon. Grey focus highlight should seen on 'Return to color picker' (X) icon. This is a regression issue, broken in M-65 series, below is manual regression range. Good build: 65.0.3284.0 Bad build: 65.0.3285.0 You are probably looking for a change made after 521548 (known good), but no later than 521549 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/65b472737b0c1100ee672b9b89c3d2439defb654..09f677bd1562c40825b936f2af6c4d2232a3d585 Suspect: https://chromium.googlesource.com/chromium/src/+/09f677bd1562c40825b936f2af6c4d2232a3d585 @aboxhall: Kindly help to reassign, if your changes are not related to this issue. Kindly review the attached screen-cast for reference.
,
Dec 7 2017
My change caused this change, because it changed the DOM order of the palette panel. I propose focusing the close button immediately, which will still be different from the old behaviour, but will allow using the keyboard.
,
Dec 7 2017
(@aboxhall: are those overlapping labels in palette fixed?)
,
Dec 7 2017
,
Dec 11 2017
You can still focus it via subsequent Tab presses. Given that it can't be opened from keyboard at all, I think it is fine. |
||
►
Sign in to add a comment |
||
Comment 1 by msrchandra@chromium.org
, Dec 6 2017