New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792348 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Added color vanishes on color picker window of Dev tools.

Reported by pranjali...@etouch.net, Dec 6 2017

Issue description

Chrome Version: 65.0.3286.0 (Official Build) 7f87a643cf9d5de271f2b6adeb7e30d6a5f8eb5d-refs/heads/master@{#521956}(64-bit)

OS:Windows(7,8,10).

Steps to reproduce:
1.Launch Chrome and Open DevTools window.
2.Go to Style section and click to open color picker window.
3.Select 'Custom' option from 'Color Palettes' and click on '+' icon.
4.Now click on added added color and observe.

Actual Result:Added color vanishes after clicking on it.
Expected Result:Added color should not vanishes after clicking on it.

This is a regression issue, broken in M-65 series, Using the per-revision bisect providing the bisect results,

Good build: 65.0.3284.0
Bad Build: 65.0.3285.0

You are probably looking for a change made after 521548 (known good), but no later than 521549 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/65b472737b0c1100ee672b9b89c3d2439defb654..09f677bd1562c40825b936f2af6c4d2232a3d585

Suspect: https://chromium.googlesource.com/chromium/src/+/09f677bd1562c40825b936f2af6c4d2232a3d585

@aboxhall: Kindly help to reassign, if your changes are not related to this issue.
 
Actual_Devtools.mp4
353 KB View Download
Expected_Devtools.mp4
472 KB View Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a

commit 43225a397b57f9df2b5fbfa2a7917d89bbf6f09a
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Dec 07 04:52:32 2017

[Devtools] Rename paletteColorsContainer back to paletteContainer

Several places in the code I'd overlooked were referring to "paletteContainer", so I felt it was safest to just put it back the way it was.

Bug:  792348 ,  792342 
Change-Id: I144752c1436500d4167190060f675b0115ee8a14
Reviewed-on: https://chromium-review.googlesource.com/812584
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522340}
[modify] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js
[modify] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css

Labels: TE-Verified-M65 TE-Verified-65.0.3288.0
Rechecked the above issue on Win(7,8,10) OS with latest canary chrome version :65.0.3288.0 and the fix is working as intended.
Kindly refer the attached screen cast for reference.
Actual_result.mov
2.6 MB Download
Status: Fixed (was: Assigned)

Sign in to add a comment