The transparency of the AEC3 has decreased since M63 |
|||||||||
Issue descriptionIn some scenarios the transparency to nearend of AEC3 has decreased compared to how it was in M63. This seem to particularly occcur when the microphone signal is saturated.
,
Dec 6 2017
,
Dec 7 2017
,
Dec 7 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7 2017
Approving merge to M64. Branch:3282
,
Dec 8 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/23da794d6675865bc57033f405106ddfc113a69d commit 23da794d6675865bc57033f405106ddfc113a69d Author: Per Åhgren <peah@webrtc.org> Date: Fri Dec 08 22:51:02 2017 Merge of Reverted the new handling of saturated echoes in AEC3 This CL reverts the changes introduced that handles echoes in AEC3. The revert is done to match the behavior which is in M63. TBR=henrik.lundin@webrtc.org, gustaf@webrtc.org (cherry picked from commit 63b494dff72d8e8638b2bfc60e55b351713bf6cf) Bug: webrtc:8615 , chromium:792346 Change-Id: I128ccb17dc359c7889a701a2faaaf06be40f86dd Reviewed-on: https://webrtc-review.googlesource.com/30140 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#21117} Reviewed-on: https://webrtc-review.googlesource.com/31481 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/64@{#4} Cr-Branched-From: aede67a199ae0552074bfec4bb03cc9a6a5fba0f-refs/heads/master@{#20918} [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/aec3_common.h [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/aec_state.h [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/matched_filter.cc [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/residual_echo_estimator.cc [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/subtractor.cc [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/subtractor.h [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/suppression_gain.cc [modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/include/audio_processing.h
,
Dec 8 2017
,
Dec 11 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2017
Please merge this issue to M64 branch 3282 if it has been verified in canary. The sooner the better. Thanks!
,
Dec 14 2017
The issue was successful on Dec 8. Should I remove the merge labels?
,
Dec 18 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 6 2017