New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792346 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 792472



Sign in to add a comment

The transparency of the AEC3 has decreased since M63

Project Member Reported by peah@chromium.org, Dec 6 2017

Issue description

In some scenarios the transparency to nearend of AEC3 has decreased compared to how it was in M63. This seem to particularly occcur when the microphone signal is saturated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/63b494dff72d8e8638b2bfc60e55b351713bf6cf

commit 63b494dff72d8e8638b2bfc60e55b351713bf6cf
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Dec 06 11:04:22 2017

Reverted the new handling of saturated echoes in AEC3

This CL reverts the changes introduced that handles echoes in AEC3.
The revert is done to match the behavior which is in M63.

Bug:  webrtc:8615 , chromium:792346 
Change-Id: I128ccb17dc359c7889a701a2faaaf06be40f86dd
Reviewed-on: https://webrtc-review.googlesource.com/30140
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21117}
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/aec3_common.h
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/matched_filter.cc
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/subtractor.h
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/aec3/suppression_gain.cc
[modify] https://crrev.com/63b494dff72d8e8638b2bfc60e55b351713bf6cf/modules/audio_processing/include/audio_processing.h

Comment 2 by peah@chromium.org, Dec 6 2017

Blocking: 792472

Comment 3 by peah@chromium.org, Dec 7 2017

Labels: Merge-Request-64
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 7 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64. Branch:3282
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017

Labels: merge-merged-64
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/23da794d6675865bc57033f405106ddfc113a69d

commit 23da794d6675865bc57033f405106ddfc113a69d
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Dec 08 22:51:02 2017

Merge of Reverted the new handling of saturated echoes in AEC3

This CL reverts the changes introduced that handles echoes in AEC3.
The revert is done to match the behavior which is in M63.

TBR=henrik.lundin@webrtc.org, gustaf@webrtc.org

(cherry picked from commit 63b494dff72d8e8638b2bfc60e55b351713bf6cf)

Bug:  webrtc:8615 , chromium:792346 
Change-Id: I128ccb17dc359c7889a701a2faaaf06be40f86dd
Reviewed-on: https://webrtc-review.googlesource.com/30140
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#21117}
Reviewed-on: https://webrtc-review.googlesource.com/31481
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/64@{#4}
Cr-Branched-From: aede67a199ae0552074bfec4bb03cc9a6a5fba0f-refs/heads/master@{#20918}
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/aec3_common.h
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/matched_filter.cc
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/subtractor.cc
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/subtractor.h
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/aec3/suppression_gain.cc
[modify] https://crrev.com/23da794d6675865bc57033f405106ddfc113a69d/modules/audio_processing/include/audio_processing.h

Comment 7 by peah@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 11 2017

Cc: abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by cma...@chromium.org, Dec 13 2017

Please merge this issue to M64 branch 3282 if it has been verified in canary. The sooner the better. Thanks!

Comment 10 by peah@chromium.org, Dec 14 2017

The issue was successful on Dec 8. Should I remove the merge labels?
Labels: -Merge-Approved-64

Sign in to add a comment