New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792342 link

Starred by 1 user
Status: Fixed
Owner:
aboxhall@chromium.org
Closed: Dec 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Weird overlapping of color index is seen on Colorpicker window.

Reported by dchau...@etouch.net, Dec 6 2017 
Chrome Version: 65.0.3286.0 (Official Build)7f87a643cf9d5de271f2b6adeb7e30d6a5f8eb5d-refs/heads/master@{#521956} 32/64-bit.
OS: Win(7,8,10)

What steps will reproduce the problem?
1. Launch Chrome and Open DevTools window.
2. Go to Style section and click to open colorpicker window.
3. Now click on second bidirectional arrow to open 'Color Palettes' and observe.

Weird overlapping of color index is seen.
No such overlapping should seen.

This is a regression issue, broken in M-65 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Dec 6 2017

Labels: hasbisect-per-revision
Owner: aboxhall@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range.

Good build: 65.0.3285.0
Bad build: 65.0.3286.0

You are probably looking for a change made after 521548 (known good), but no later than 521549 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/22bf150b6fad408e508eb0efcb1bd7938f2b451b..e7898d1ac109b4081cba963ea6c4aab9704ec135

Suspect: https://chromium.googlesource.com/chromium/src/+/e7898d1ac109b4081cba963ea6c4aab9704ec135

@aboxhall: Kindly help to reassign, if your changes are not related to this issue.

NOTE: Will update the behavior of Mac and Linux OS once builds will be available.

Kindly review the attached screen-cast for reference.
ColorPicker_Screenshot.png
42.2 KB View Download
Actual behavior.mp4
978 KB View Download
Expected behavior.mp4
482 KB View Download

Comment 2 by dchau...@etouch.net, Dec 6 2017

Labels: OS-Mac
This issue is also reproducible on Mac S X(10.11.6,10.12.3). Will soon update the behavior of Linux OS.

Comment 3 by msrchandra@chromium.org, Dec 6 2017

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a

commit 43225a397b57f9df2b5fbfa2a7917d89bbf6f09a
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Dec 07 04:52:32 2017

[Devtools] Rename paletteColorsContainer back to paletteContainer

Several places in the code I'd overlooked were referring to "paletteContainer", so I felt it was safest to just put it back the way it was.

Bug:  792348 ,  792342 
Change-Id: I144752c1436500d4167190060f675b0115ee8a14
Reviewed-on: https://chromium-review.googlesource.com/812584
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522340}
[modify] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js
[modify] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css

Comment 5 by dchau...@etouch.net, Dec 8 2017

Labels: TE-Verified-M65 TE-Verified-65.0.3288.0
Update:-
 Tested this issue on Windows (7,8,10), Mac OS X(10.12.6,10.13.2) & Linux (14.04 LTS) machines using latest Chrome canary build# 65.0.3288.0 fix is working as expected. hence adding TE Verified labels.

Please find the attached screen-cast for reference.

Thanks..!
LatestCanary_behavior.mp4
589 KB View Download

Comment 6 by aboxhall@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment