New issue
Advanced search Search tips

Issue 792329 link

Starred by 1 user
Status: Fixed
Owner:
kojii@chromium.org
Closed: Dec 2017
Cc:
ikilpatrick@chromium.org
qyears...@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Enable LayoutNGPaintFragments on build bot linux_layout_tests_layout_ng

Project Member Reported by kojii@chromium.org, Dec 6 2017 
Could you please enable LayoutNGPaintFragments runtime flag on layout_ng bots.

As far as I understand from old changes, this is about testing/buildbot/chromium.fyi.json?

  "args": [
-    "--additional-driver-flag=--enable-blink-features=LayoutNG"
+    "--additional-driver-flag=--enable-blink-features=LayoutNG",
+    "--additional-driver-flag=--enable-blink-features=LayoutNGPaintFragments",   
  ],

I believe with this change, the bot can still use FlagExpectations/enable-blink-features=LayoutNG. I'm testing this in a private CL[1] but we can rename the FlagExpectations if needed.

There will be ~2000 additional failures by doing this. I'll maintain the FlagExpectations as soon as this is enabled.

/cc dpranke@ as per the blink-dev@ e-mail.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/776334/37

Comment 1 by kojii@chromium.org, Dec 6 2017 

Correction: please also add "--enable-slimming-paint-v175"

  "args": [
-    "--additional-driver-flag=--enable-blink-features=LayoutNG"
+    "--additional-driver-flag=--enable-blink-features=LayoutNG",
+    "--additional-driver-flag=--enable-blink-features=LayoutNGPaintFragments",
+    "--additional-driver-flag=--enable-slimming-paint-v175"
  ],

Comment 2 by e...@chromium.org, Dec 6 2017 

+1

Comment 3 by dpranke@chromium.org, Dec 6 2017 

chromium.fyi isn't currently "locked down", so feel free to make such a change at any time, but thanks for letting me know.

Comment 4 by dpranke@chromium.org, Dec 6 2017

Owner: kojii@chromium.org
(I'm assuming you can make the change yourself given the above).
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb

commit eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb
Author: Koji Ishii <kojii@chromium.org>
Date: Thu Dec 07 17:58:27 2017

[LayoutNG] Enable LayoutNGPaintFragments in virtual/layout_ng

This patch enables LayoutNGPaintFragments in virtual/layout_ng,
and also merges layout_ng and layout_ng_paint.

There are additional failures; some are just to be rebaselined.
I will analyze and cleanup in following patches.

Bug:  792329 ,  714962 
Change-Id: Ie61d9672e3d4f44847ef8771214c16e993245943
Reviewed-on: https://chromium-review.googlesource.com/804803
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522469}
[modify] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/inline/README.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/inline/absolute-positioned-block-in-centred-block-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/README.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/floats-in-block-layout-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/inline-direction-positioning-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/margin-collapse-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/root-lr-basic-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/self-collapsing-block-expected.txt
[rename] https://crrev.com/eb83e8cfdaa957369e2bc1151e7b0a26d0b4a3fb/third_party/WebKit/LayoutTests/virtual/layout_ng/fast/writing-mode/table-percent-width-quirk-expected.txt
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08f8a8abbcdf4b5a9a2fd153e0a65a80535cb265

commit 08f8a8abbcdf4b5a9a2fd153e0a65a80535cb265
Author: Koji Ishii <kojii@chromium.org>
Date: Fri Dec 08 07:28:56 2017

Enable LayoutNGPaintFragments on build bot linux_layout_tests_layout_ng

This patch enables LayoutNGPaintFragments and slimming-paint v175
on linux_layout_tests_layout_ng.

Following build# from layout_ng bots are included:
2423 2428

Still more flaky results are expected for layout_ng bots. I will
maintain the FlagExpectations when this is landed.

Bug:  792329 ,  714962 
Change-Id: I2bca54943a1db545be3e33059ac55091ac885fa4
Reviewed-on: https://chromium-review.googlesource.com/813139
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522733}
[modify] https://crrev.com/08f8a8abbcdf4b5a9a2fd153e0a65a80535cb265/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/08f8a8abbcdf4b5a9a2fd153e0a65a80535cb265/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

Comment 7 by kojii@chromium.org, Dec 8 2017

Status: Fixed (was: Untriaged)
Thank you all!
►

Sign in to add a comment