[css-typed-om] CSSUrlImageValue should set attributes to null if there was an error |
||
Issue descriptionWhen there's an error loading a CSSUrlImageValue, its intrinsicWidth/Height/Ratio should be set to null. Currently they're being set to 0. Test failure (typedcssom/stylevalue-subclasses/cssUrlImageValue.html): FAIL Loading a CSSURLImageValue from a URL to an invalid image sets its state to error assert_equals: expected (object) null but got (number) 0 Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssimagevalue
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35cea0d40d8d99a12955d83449fb79a7c5680fe1 commit 35cea0d40d8d99a12955d83449fb79a7c5680fe1 Author: Shanmuga Pandi M <shanmuga.m@samsung.com> Date: Thu Dec 07 05:18:11 2017 [css-typed-om] CSSUrlImageValue should set attributes to null if there was an error As per spec[1], intrinsicWidth, intrinsicHeight, and intrinsicRatio should return NULL , if state is other than "loaded". [1] https://drafts.css-houdini.org/css-typed-om-1/#cssimagevalue Bug: 792328 Change-Id: I9d3c7014136f6f2a7bd6b350ff4083389436cc54 Reviewed-on: https://chromium-review.googlesource.com/810288 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#522346} [modify] https://crrev.com/35cea0d40d8d99a12955d83449fb79a7c5680fe1/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html [delete] https://crrev.com/0794bed59241414795527d25278797573b8926df/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue-expected.txt [modify] https://crrev.com/35cea0d40d8d99a12955d83449fb79a7c5680fe1/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.cpp [modify] https://crrev.com/35cea0d40d8d99a12955d83449fb79a7c5680fe1/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValueTest.cpp
,
Dec 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by shanmug...@samsung.com
, Dec 6 2017Status: Assigned (was: Available)