New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792312 link

Starred by 1 user
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

desktop-pwas: Clicking proceed through a Safe Browsing interstitial should open a new tab

Project Member Reported by ortuno@chromium.org, Dec 6 2017 
When users are in an app window and a Safe Browsing interstitial is shown, clicking on "Proceed" should open a new tab and continue the navigation there. That way we can show more of our security UI.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8887dca55e7debbcf38f0349f2ce1859b26ed7ce

commit 8887dca55e7debbcf38f0349f2ce1859b26ed7ce
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Jan 16 22:29:32 2018

desktop-pwas: Open a new tab when users proceed through safe browsing in an app

Changes the safe browsing interstitial so that, when in an app window,
clicking "Proceed" opens a new tab in a regular browser and continues
the navigation there.

Bug:  792312 
Change-Id: Iecbd2da365005e4d13273cd93243e9989fcd7c96
Reviewed-on: https://chromium-review.googlesource.com/809995
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529510}
[modify] https://crrev.com/8887dca55e7debbcf38f0349f2ce1859b26ed7ce/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/8887dca55e7debbcf38f0349f2ce1859b26ed7ce/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[add] https://crrev.com/8887dca55e7debbcf38f0349f2ce1859b26ed7ce/chrome/browser/safe_browsing/safe_browsing_controller_client.cc
[add] https://crrev.com/8887dca55e7debbcf38f0349f2ce1859b26ed7ce/chrome/browser/safe_browsing/safe_browsing_controller_client.h
[modify] https://crrev.com/8887dca55e7debbcf38f0349f2ce1859b26ed7ce/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Comment 2 by ortuno@chromium.org, Jan 16 2018

Status: Fixed (was: Started)
►

Sign in to add a comment