New issue
Advanced search Search tips

Issue 792308 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: May 2018
Cc:
rbpotter@chromium.org
halcanary@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add metrics for printed PDF / EMF sizes

Project Member Reported by thestig@chromium.org, Dec 6 2017 
Given numerous bugs about printing spool sizes being too big, causing printing to be slow, it would be good to keep track of stats on:

1) The size of the PDF sent to the printer. (All platforms)
2) The size of the converted EMF file. (Windows)
3) The size of the converted PostScript file. (Windows)
4) The size of the rasterized PWG file. (Platforms that support Print Preview, so not Android)

For the above, we would want size divided by number of pages, and maybe also the absolute size. We will always keep track of (1) for a print job, whereas (2), (3) and (4) are only when applicable.

This is not a replacement for a benchmark, but it may help alert us to potential regressions in the printing pipeline.

Comment 1 by thestig@chromium.org, Dec 12 2017

Components: Internals>Printing
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494ded10da7bb167b622590d2ab7b90b13bcc1fd

commit 494ded10da7bb167b622590d2ab7b90b13bcc1fd
Author: Lei Zhang <thestig@chromium.org>
Date: Tue May 08 21:53:27 2018

Printing: Add metrics for PDF sent out for printing.

BUG= 792308 

Change-Id: Id5b4b80b72160b76f377134fc536ca1820c1f514
Reviewed-on: https://chromium-review.googlesource.com/1049271
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556974}
[modify] https://crrev.com/494ded10da7bb167b622590d2ab7b90b13bcc1fd/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/494ded10da7bb167b622590d2ab7b90b13bcc1fd/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d99dda011eb3574845d957a0fece07e29cf37bc0

commit d99dda011eb3574845d957a0fece07e29cf37bc0
Author: Lei Zhang <thestig@chromium.org>
Date: Tue May 22 17:42:10 2018

Printing: Add metrics for PDF to native format conversions on Windows.

BUG= 792308 

Change-Id: Iac85f6f2cf2db684b8cddb7926d4a032e154ee41
Reviewed-on: https://chromium-review.googlesource.com/1056472
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560687}
[modify] https://crrev.com/d99dda011eb3574845d957a0fece07e29cf37bc0/chrome/browser/printing/pdf_to_emf_converter.cc
[modify] https://crrev.com/d99dda011eb3574845d957a0fece07e29cf37bc0/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb

commit fbfa5e4d9547ac573aeb34e671e2266b58d61dcb
Author: Lei Zhang <thestig@chromium.org>
Date: Thu May 24 20:12:40 2018

Printing: Add metrics for PDF to PWG Raster conversions.

BUG= 792308 

Change-Id: I151965cc99c4bd757176c3af87971e28f6c347da
Reviewed-on: https://chromium-review.googlesource.com/1069560
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561599}
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/browser/printing/cloud_print/privet_http_unittest.cc
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/browser/printing/pwg_raster_converter.cc
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/browser/printing/pwg_raster_converter.h
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/browser/printing/pwg_raster_converter_browsertest.cc
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/services/printing/pdf_to_pwg_raster_converter.cc
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/chrome/services/printing/public/mojom/pdf_to_pwg_raster_converter.mojom
[modify] https://crrev.com/fbfa5e4d9547ac573aeb34e671e2266b58d61dcb/tools/metrics/histograms/histograms.xml

Comment 5 by thestig@chromium.org, May 24 2018

Labels: -M-65 M-68
Status: Fixed (was: Assigned)
►

Sign in to add a comment