Background: https://chromium-review.googlesource.com/c/chromium/src/+/809299#message-562c7ba4c4761719f2711f86ccff76dc041108e7 Currently Worklet accepts LocalFrame as a constructor argument, but in some cases the local frame object can be null. Consider changing Worklet's constructor argument to ExecutionContext to avoid potential NULL deferencing issue.
Thank you for filing this. I'll take a look.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c commit a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Dec 06 07:07:50 2017 Worklet: Remove dependency on LocalFrame from Worklet This is a clean-up and doesn't change behavior. Worklets care about the lifetime of Document not LocalFrame. To make it clearer, this CL removes dependency on LocalFrame from Worklet. Bug: 792307 , 792108 Change-Id: I24268c2f59efa70f26a0024bb02ee8a35d01ba7f Reviewed-on: https://chromium-review.googlesource.com/810405 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522033} [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/core/workers/Worklet.cpp [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/core/workers/Worklet.h [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/animationworklet/AnimationWorklet.cpp [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/animationworklet/AnimationWorklet.h [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.cpp [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.h [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp [modify] https://crrev.com/a3acb2d50c09040f45c2f2efe8f624cb63e3bf2c/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
Comment 1 by nhiroki@chromium.org
, Dec 6 2017Status: Started (was: Available)