diagnostics_writer.cc is spammy in browser tests on Chrome OS |
|||||
Issue descriptionWe have a bunch of output from diagsnostics_writer.cc which uses LOG(WARNING) to force output to the log. Since this information is not meaningful on Linux and just adds noise to the tests, we should consider disabling it for non chromeos on Linux (which would include browser tests).
,
Dec 6 2017
,
Dec 6 2017
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16863621cc622cdabb42a3dc5f718d9349c44844 commit 16863621cc622cdabb42a3dc5f718d9349c44844 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Dec 07 23:31:19 2017 CrOS: Skip diagnostics when not running on a device The diagnostics output is intended to investigate corrupted profiles when recovering from a crash on a device. This output has no value when not running on a device (e.g. browser tests). Bug: 792304 TBR: rockot@ for cros specific change lgtm'd by jamescook@ + xiyuan@ TEST: Navigate to chrome://inducebrowsercrashforrealz/, confirm diagnostics_writer.cc output in /var/log/ui.LATEST Change-Id: I7ad72087d3cfa4ec4fa3e76a1f9f62ca73e4cb3d Reviewed-on: https://chromium-review.googlesource.com/810031 Reviewed-by: Carlos Pizano <cpu@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#522610} [modify] https://crrev.com/16863621cc622cdabb42a3dc5f718d9349c44844/chrome/app/chrome_main_delegate.cc
,
Dec 7 2017
,
Jul 30
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by steve...@chromium.org
, Dec 6 2017