New issue
Advanced search Search tips

Issue 792294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Simplify enable_basic_printing / enable_print_preview build flags

Project Member Reported by thestig@chromium.org, Dec 6 2017

Issue description

Chromium has two boolean build flags for printing:
- enable_basic_printing: controls the ability to print with the native print dialog
- enable_print_preview: controsl the print preview feature

In theory, all 4 combinations of the two booleans can work. The reason there are 4 possible states is:

1) In the beginning, we had enable_basic_printing only. (2 states)
2) Then we added enable_print_preview, which implied enable_basic_printing. (3 states)
3) Then ChromeOS wanted enable_print_preview without enable_basic_printing, so we added support for this build configuration. (4 states)

but with local CUPS printing, ChromeOS no longer uses the state we added support for in (3). Given this, should we move from the current state of (3) back to (2) ?
 

Comment 1 by skau@chromium.org, Dec 6 2017

I'd be in favor of simplifying the flags so that enable_print_preview implies enable_basic_printing.
Status: Available (was: Untriaged)
We have a bunch of big changes in flight. Maybe someone can get to this after they all land.
Owner: thestig@chromium.org
Status: Assigned (was: Available)
To outline the 3 possible states:

1) No printing support at all: Chromecast and other embedded platforms?
2) Basic printing only: Android.
3) Full, AKA basic printing and Print Preview: Desktop platforms, including ChromeOS.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48a4a5263a9c914eab2a0ef9d71c836cc2771792

commit 48a4a5263a9c914eab2a0ef9d71c836cc2771792
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 17 20:18:44 2018

Make enable_print_preview require enable_basic_printing

Also add OWNERS for components/resources/printing_resources.grdp

BUG= 792294 

Change-Id: If488698218b7a713db961d54c7a1cf811ab94a8b
Reviewed-on: https://chromium-review.googlesource.com/989426
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jianzhou Feng <jzfeng@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551457}
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/app/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/app/chrome_dll.rc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/about_flags.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/printing/print_view_manager.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/printing/print_view_manager.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/cocoa/accelerators_cocoa.mm
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/common/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/common/features.gni
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/renderer/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/test/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/chrome/utility/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/printing/common/print_messages.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/printing/renderer/print_render_frame_helper.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/printing/renderer/print_render_frame_helper_linux.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/printing/service/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/printing/test/print_render_frame_helper_browsertest.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/resources/OWNERS
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/resources/printing_resources.grdp
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/components/test/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/content/browser/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/content/renderer/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/browser/protocol/page_handler.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/browser/protocol/page_handler.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/renderer/headless_content_renderer_client.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/headless/lib/utility/headless_content_utility_client.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/printing/buildflags/BUILD.gn
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/printing/buildflags/buildflags.gni
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/printing/print_job_constants.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/printing/print_job_constants.h
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/printing/printing_context.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/printing/printing_context_win.cc
[modify] https://crrev.com/48a4a5263a9c914eab2a0ef9d71c836cc2771792/skia/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment