New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792292 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] AttributeError: 'NoneType' object has no attribute 'itervalues'

Project Member Reported by wylieb@chromium.org, Dec 6 2017

Issue description

Owner: robert...@chromium.org
Status: Started (was: Untriaged)
I think that because of the change to use StructureObject the 'tests' key is contains None rather than being absent. (in the input to ProcessSwarmingTasksResultPipeline see https://findit-for-me.appspot.com/_ah/pipeline/status?root=b5cf1fb2dc3c4d05845fed0263c2dfae#pipeline-b5cf1fb2dc3c4d05845fed0263c2dfae for example)

I am making a change to treat the key containing None the same as if the key was absent.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8b0834e806cd654243ba4021f33c6724e127392f

commit 8b0834e806cd654243ba4021f33c6724e127392f
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Dec 06 04:50:54 2017

[Findit] Treat an empty 'tests' key same as absent.

R=wylieb,stgao,lijeffrey
BUG= 792292 

Change-Id: I98d183a800d1967b1233e318dc9dfa91f3cbd372
Reviewed-on: https://chromium-review.googlesource.com/810035
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/8b0834e806cd654243ba4021f33c6724e127392f/appengine/findit/waterfall/process_swarming_tasks_result_pipeline.py

Status: Fixed (was: Started)

Sign in to add a comment