New issue
Advanced search Search tips

Issue 792266 link

Starred by 1 user
Status: Fixed
Owner:
vadimsh@chromium.org
Closed: Dec 2017
Cc:
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 771001



Sign in to add a comment

Allow recipe properties to be read from environment variables

Project Member Reported by vadimsh@chromium.org, Dec 6 2017 
This is useful in some situations, e.g. for https://bugs.chromium.org/p/chromium/issues/detail?id=771001#c16
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/3b02d79e002f4cea48de2f512157eb2def6081d1

commit 3b02d79e002f4cea48de2f512157eb2def6081d1
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Dec 07 22:42:19 2017

Allow properties to load default values from environment.

R=iannucci@chromium.org
BUG= 792266 

Change-Id: Ifb2550ac7d9bcb0386d78d6115f0a7ce86461561
Reviewed-on: https://chromium-review.googlesource.com/813500
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_tryserver.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_engine/unittests/loader_test.py
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_git.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_scheduled.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/lists.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/basic.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.py
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_engine/loader.py
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_engine/unittests/recipe_api_test.py
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/.gitignore
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_both.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_gerrit.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/README.recipes.md
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_engine/run.py
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_generic.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/buildbot_git_scheduled.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_engine/test.py
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_modules/properties/examples/full.expected/dicts.json
[modify] https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1/recipe_engine/recipe_api.py

Comment 2 by vadimsh@chromium.org, Dec 15 2017

Status: Fixed (was: Assigned)
Done presumably.
►

Sign in to add a comment