New issue
Advanced search Search tips

Issue 792227 link

Starred by 1 user
Status: Fixed
Owner:
rogerm@chromium.org
Closed: Jul 24
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[autofill] Allow the server to vote that a field should not be autofilled.

Project Member Reported by rogerm@chromium.org, Dec 5 2017 
The server currently has no way to tell chrome that a given field should not be autofilled (i.e., to tell chrome not to trust its heuristics).

Chrome expects that the server returns a valid type or NO_SERVER_DATA. It has a DCHECK that the server does not return UNKNOWN_TYPE.

Chrome should be updated to accept UNKNOWN_TYPE as a valid response form the server. These predictions should be treated just like any other prediction from the server (as an override for the heuristics, but not the autocomplete attribute).
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5314e9547e95109884a318bbc4806fcc1dfd1c11

commit 5314e9547e95109884a318bbc4806fcc1dfd1c11
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Dec 08 18:49:22 2017

[autofill] Support UNKNOWN_TYPE predictions from the server.

Prior to this CL, Chrome would DCHECK if the server returned
UNKNOWN_TYPE for a given field.

After this CL Chrome will accept UNKNOWN_TYPE as an override for the
heuristic vote (i.e., it will treat UNKNOWN_TYPE just like any other
server response).

Autocomplete type hints provided by the developer continue to supersede
both heuristic and server predictions.

Bug:  792227 
Change-Id: I8af66ff97edb1e18b50d6c3773bb9dfe2b0f16b3
Reviewed-on: https://chromium-review.googlesource.com/809909
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522829}
[modify] https://crrev.com/5314e9547e95109884a318bbc4806fcc1dfd1c11/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/5314e9547e95109884a318bbc4806fcc1dfd1c11/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/5314e9547e95109884a318bbc4806fcc1dfd1c11/components/autofill/core/browser/form_structure_unittest.cc

Comment 2 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Started)

Comment 3 by rogerm@chromium.org, Jul 24

Status: Fixed (was: Untriaged)
►

Sign in to add a comment