New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We should have a chrome printing service to host the printing related converter interfaces.

Project Member Reported by jcivelli@chromium.org, Dec 5 2017

Issue description

The printing related converter interfaces (PdfToPwgRaster, PdfToEmf) should be moved to a specific printing service under chrome/services.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407c3fcf555e8df54e8236531847720a0c3cbbed

commit 407c3fcf555e8df54e8236531847720a0c3cbbed
Author: Jay Civelli <jcivelli@chromium.org>
Date: Thu Dec 14 00:25:27 2017

Moving the PdfToPwgConverter service to a new chrome printing service.

In preparation for more printing related servicification (PDF to EMF
converter, printer capabilities...), creating a new Chrome printing
service to host these interfaces and moving PdfToPwgRasterConverter
service there.

There is no change in logic.

Bug:  792225 
Change-Id: I2c71a9e035dafc1ade84e71da6d71a9ca38277cd
Reviewed-on: https://chromium-review.googlesource.com/809619
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523950}
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/app/BUILD.gn
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/app/generated_resources.grd
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/browser/DEPS
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/browser/printing/pwg_raster_converter.cc
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/common/printing/BUILD.gn
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/common/printing/OWNERS
[delete] https://crrev.com/4a2337dde676a76d4bfb99bf1d92bd0efda57e29/chrome/common/printing/pdf_render_settings.typemap
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/common/printing/pdf_to_emf_converter.mojom
[delete] https://crrev.com/4a2337dde676a76d4bfb99bf1d92bd0efda57e29/chrome/common/printing/pdf_to_pwg_raster_converter.typemap
[delete] https://crrev.com/4a2337dde676a76d4bfb99bf1d92bd0efda57e29/chrome/common/printing/typemaps.gni
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/BUILD.gn
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/DEPS
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/OWNERS
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/manifest.json
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/pdf_to_pwg_raster_converter.cc
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/pdf_to_pwg_raster_converter.h
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/printing_service.cc
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/printing_service.h
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/BUILD.gn
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/OWNERS
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/constants.mojom
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_render_settings.mojom
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_render_settings.typemap
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_render_settings_struct_traits.cc
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_render_settings_struct_traits.h
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_to_pwg_raster_converter.mojom
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_to_pwg_raster_converter.typemap
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_to_pwg_raster_converter_struct_traits.cc
[rename] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/pdf_to_pwg_raster_converter_struct_traits.h
[add] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/services/printing/public/interfaces/typemaps.gni
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/typemaps.gni
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/utility/BUILD.gn
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/utility/DEPS
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/chrome/utility/chrome_content_utility_client.cc
[delete] https://crrev.com/4a2337dde676a76d4bfb99bf1d92bd0efda57e29/chrome/utility/printing/OWNERS
[modify] https://crrev.com/407c3fcf555e8df54e8236531847720a0c3cbbed/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea91022c4d43556eb4cda4235cdd5799f8690d1

commit 0ea91022c4d43556eb4cda4235cdd5799f8690d1
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Dec 19 06:27:45 2017

Fix a printing build dependency after r523950.

BUG= 792225 

Change-Id: Ieb33a72d5b693ac7669d45ea6ed912aedd6c8ae1
Reviewed-on: https://chromium-review.googlesource.com/833354
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524954}
[modify] https://crrev.com/0ea91022c4d43556eb4cda4235cdd5799f8690d1/chrome/browser/BUILD.gn

Sign in to add a comment