New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792201 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros tryjob tool needs better messaging for branched configs and tryjob safeness.

Project Member Reported by gwendal@chromium.org, Dec 5 2017

Issue description

I need to build a eve factory image:
I ran: cros tryjob -g 809486 --branch factory-eve-9667.B --remote eve-factory-tryjob
I checked eve-factory-tryjob is in cros tryjob --list

but the builder is not happy:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/factory/builds/19
ERROR: No such configuraton target: "eve-factory-tryjob".
Comparing with build factory #17 (fizz-factory-trybot), the extra_args look identical.





 
cros tryjob -g 809486 --branch factory-eve-9667.B --remote eve-factory

These configs are not tryjob safe:
  eve-factory
Consider these configs instead:
  eve-factory-tryjob
See go/cros-explicit-tryjob-build-configs-psa.
Are you sure you want to continue? (yes/No)? 

Say yes to the confirmation question.


Build config names are per-branch. However it's not possible for --list know what's on a branch, or for the tool to know if a branched config is tryjob safe.

The tool prompts you to use a tryjob safe config based on the master branch based on the idea that new branches WILL contain the "-tryjob" variants, and the older branches will stop being used over time.

However, those error messages probably need to be reworded to be more helpful about branches.

Summary: cros tryjob tool needs better messaging for branched configs and tryjob safeness. (was: Unable to trybot an eve factory image)
Owner: dgarr...@chromium.org
Status: WontFix (was: Untriaged)
Indeed as the build you started confirm - https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/factory/builds/20 - using eve-factory works.
Status: Assigned (was: WontFix)
I want to keep the bug and improve the messaging to the tool uses.

This shouldn't have been so confusing.
Cc: vbendeb@chromium.org

Comment 7 by no...@chromium.org, Jun 17 2018

Components: -Infra>Platform>Buildbot>TryServer Infra>Client>ChromeOS
Cc: mikenichols@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1c3887f3534e0ac6903e8218a00bc63fcf8e96b2

commit 1c3887f3534e0ac6903e8218a00bc63fcf8e96b2
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jul 20 18:41:06 2018

cros tryjob: Stop verifying branched config names.

We can't know if a given build config exists on a branch, or if it's
tryjob safe, so don't even try.

BUG= chromium:792201 
TEST=run_tests && some manual testing.

Change-Id: Ic9ac18cbedbba78cb84ed112ec163b7e85d7be9c
Reviewed-on: https://chromium-review.googlesource.com/1142613
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/1c3887f3534e0ac6903e8218a00bc63fcf8e96b2/cli/cros/cros_tryjob_unittest.py
[modify] https://crrev.com/1c3887f3534e0ac6903e8218a00bc63fcf8e96b2/cli/cros/cros_tryjob.py

Status: Fixed (was: Assigned)

Sign in to add a comment