cros tryjob tool needs better messaging for branched configs and tryjob safeness. |
|||||||||
Issue descriptionI need to build a eve factory image: I ran: cros tryjob -g 809486 --branch factory-eve-9667.B --remote eve-factory-tryjob I checked eve-factory-tryjob is in cros tryjob --list but the builder is not happy: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/factory/builds/19 ERROR: No such configuraton target: "eve-factory-tryjob". Comparing with build factory #17 (fizz-factory-trybot), the extra_args look identical.
,
Dec 5 2017
,
Dec 5 2017
,
Dec 5 2017
Indeed as the build you started confirm - https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/factory/builds/20 - using eve-factory works.
,
Dec 5 2017
I want to keep the bug and improve the messaging to the tool uses. This shouldn't have been so confusing.
,
Feb 26 2018
,
Jun 17 2018
,
Jul 17
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1c3887f3534e0ac6903e8218a00bc63fcf8e96b2 commit 1c3887f3534e0ac6903e8218a00bc63fcf8e96b2 Author: Don Garrett <dgarrett@google.com> Date: Fri Jul 20 18:41:06 2018 cros tryjob: Stop verifying branched config names. We can't know if a given build config exists on a branch, or if it's tryjob safe, so don't even try. BUG= chromium:792201 TEST=run_tests && some manual testing. Change-Id: Ic9ac18cbedbba78cb84ed112ec163b7e85d7be9c Reviewed-on: https://chromium-review.googlesource.com/1142613 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> [modify] https://crrev.com/1c3887f3534e0ac6903e8218a00bc63fcf8e96b2/cli/cros/cros_tryjob_unittest.py [modify] https://crrev.com/1c3887f3534e0ac6903e8218a00bc63fcf8e96b2/cli/cros/cros_tryjob.py
,
Jul 20
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dgarr...@chromium.org
, Dec 5 2017