Requests to fetch all_rotations.js from chromium_build need to be updated |
|||||
Issue descriptionSince the recent change to redirect from build.chromium.org to ci.chromium.org, requests to https://build.chromium.org/p/chromium/all_rotations.js no longer work. Anywhere that uses this URL should be updated, including: - SoM https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html - WPT importer: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py http://chromium-build.appspot.com/static/rotations.html also doesn't work now. This has already been updated for Findit in https://chromium-review.googlesource.com/c/infra/infra/+/784212. The URL that currently seems to work is https://build.chromium.org/deprecated/chromium/all_rotations.js, but the "deprecated" in this URL seems to indicate that this is mean tto be temporary. hinoka@, do you know what the plan is with the sheriff rotations JSON? Will this be served in the same format from ci.chromium.org? What's the source of the sheriff rotations information anyway?
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f273deec1d6f9cb62e303b7fea3e782a08ff1c0 commit 7f273deec1d6f9cb62e303b7fea3e782a08ff1c0 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Dec 05 22:53:56 2017 Update the WPT importer sheriff rotation URL. This changes the WPT import script to use the URL https://build.chromium.org/deprecated/chromium/all_rotations.js for fetching sheriff rotations. Bug: 792193 Change-Id: I64bc3396bc921cc7f1e0420f872881fb2b25ebac Reviewed-on: https://chromium-review.googlesource.com/809616 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#521877} [modify] https://crrev.com/7f273deec1d6f9cb62e303b7fea3e782a08ff1c0/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
,
Dec 5 2017
Alright, thanks :-) As of right now, https://build.chromium.org/deprecated/chromium/all_rotations.json seems to respond with 404, not sure if the *json URLs will be available on when the chromium_build app is next deployed? The change above updates WPT importer. zhangtiff@, I think that the "Current On Calls" functionality of SoM appears to not be working right now, and I think that's the main thing to update; is there another bug for that? If not this bug could be used.
,
Dec 5 2017
Thanks qyearsley! I hadn't filed a but for this yet, but it's a known issue. Fixing for SoM ASAP. :)
,
Dec 5 2017
,
Dec 6 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0751d95696db97dafa1ed45b7c69b8f3e5682a12 commit 0751d95696db97dafa1ed45b7c69b8f3e5682a12 Author: Tiff Zhang <zhangtiff@google.com> Date: Wed Dec 06 19:26:23 2017 SoM: Update on-call links. Bug:792193 Change-Id: I542e4c1d461ce12514aabc1297b52665640609c4 Reviewed-on: https://chromium-review.googlesource.com/809926 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/0751d95696db97dafa1ed45b7c69b8f3e5682a12/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
,
Dec 14 2017
This has been fixed in Sheriff-o-Matic. Feel free to file a new bug for any other places this needs to be changed. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hinoka@chromium.org
, Dec 5 2017