New issue
Advanced search Search tips

Issue 792179 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to webrtc::MetricsObserverInterface from invalid vptr in cricket::BasicPortAllocator::OnIceRegathering

Project Member Reported by ClusterFuzz, Dec 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5631246427488256

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1d6f4284a450
Crash State:
  Bad-cast to webrtc::MetricsObserverInterface from invalid vptr
  cricket::BasicPortAllocator::OnIceRegathering
  cricket::BasicPortAllocatorSession::OnNetworksChanged
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=519266:519277

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5631246427488256

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: hbos@chromium.org
Components: Blink>WebRTC>PeerConnection
The only WebRTC commit in the regression range is https://chromium.googlesource.com/chromium/src/+/27d21eb0af100f86a2dfca5bccecf60e2d71f70e, but I don't see anything obvious there that would corrupt the metrics_observer().


Project Member

Comment 2 by sheriffbot@chromium.org, Dec 6 2017

Labels: M-64
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 6 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 6 2017

Labels: Pri-1

Comment 5 by hbos@chromium.org, Dec 6 2017

Status: Assigned (was: Untriaged)
Ok. I'll investigate tomorrow.

Comment 6 by hbos@chromium.org, Dec 7 2017

Status: Started (was: Assigned)

Comment 7 by hbos@chromium.org, Dec 7 2017

Status: WontFix (was: Started)
I am unable to reproduce this, I've tried with ubsan, debug and asan builds.

Running with --use-fake-device-for-media-stream --use-fake-ui-for-media-stream to get around unrelated permission crash.

It's spamming the following in the console:
[1:19:1207/145000.702235:ERROR:sctptransport.cc(813)] SctpTransport->SendQueuedStreamResets(): Failed to send a stream reset for 1 streams: [0x00000072] Operation already in progress

I'm closing as WontFix (cannot repro) unless someone else wants to give a try. The stack trace looks completely unrelated to the CL linked in #1.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 15 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment