Check that committed interstitials work with Javascript/images/etc. disabled |
|||
Issue descriptionError pages (including committed interstitials) shouldn't be subject to content setting rules like blocking JS. It seems likely that this works properly already, because otherwise error pages would be broken when you have content settings adjusted, but we should double-check to be sure. There is a special code path for making sure content settings don't affect interstitial overlays (https://cs.chromium.org/chromium/src/chrome/renderer/content_settings_observer.cc?l=321), so we'll need to either adjust that to work with committed interstitials, or remove it if it's redundant. (see https://bugs.chromium.org/p/chromium/issues/detail?id=322948 for history)
,
Jan 11 2018
Assigning this one to myself since it's related to the JS bindings.
,
Feb 2 2018
Tested this one by hand and it seems committed interstitials do work with images/JS disabled so that line can be removed once committed interstitials are the only codepath. Do you think it would be worth it to add a test that checks it still works with JS disabled?
,
Feb 4 2018
Re #3: https://cs.chromium.org/chromium/src/chrome/browser/ssl/ssl_browsertest.cc?q=ssl_browsertest&sq=package:chromium&dr&l=4069 purports to test this situation already, so if that test is passing and you tested manually, I think we can just mark this as Fixed. Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Dec 5 2017