InfoBar stopped showing for NoScript previews [in Dev/Canary] |
|||||||
Issue descriptionRepro: - Enable NoScript via flag - Disable Offline Page Previews via flag - Override Effective Connection Type to 2G by flag - Navigate to https://wikipedia.org and notice that no preview is shown
,
Dec 5 2017
,
Dec 5 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ffc80d6d222e782e852cd4e1a19029d08d4145e commit 1ffc80d6d222e782e852cd4e1a19029d08d4145e Author: Doug Arnett <dougarnett@chromium.org> Date: Tue Dec 05 22:02:31 2017 Fixes InfoBar presentation for NoScript preview Bug: 792133 Change-Id: Iaa99ae16b359560f60e23c07cace1241781b6bbd Reviewed-on: https://chromium-review.googlesource.com/809296 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#521846} [modify] https://crrev.com/1ffc80d6d222e782e852cd4e1a19029d08d4145e/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/1ffc80d6d222e782e852cd4e1a19029d08d4145e/chrome/browser/previews/previews_browsertest.cc
,
Dec 6 2017
Verified on Canary 65.0.3286.0 for https: navigations. [separate issue for http->https redirections - 792275]
,
Dec 6 2017
,
Dec 7 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9eea011ee9caab757a583f54c33c31cd7dca3a84 commit 9eea011ee9caab757a583f54c33c31cd7dca3a84 Author: Doug Arnett <dougarnett@chromium.org> Date: Thu Dec 07 21:34:55 2017 Fixes InfoBar presentation for NoScript preview Bug: 792133 Change-Id: Iaa99ae16b359560f60e23c07cace1241781b6bbd Reviewed-on: https://chromium-review.googlesource.com/809296 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521846}(cherry picked from commit 30f1c880138b16d35d5c3a796a107434a971661e) Reviewed-on: https://chromium-review.googlesource.com/815337 Reviewed-by: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#78} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/9eea011ee9caab757a583f54c33c31cd7dca3a84/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/9eea011ee9caab757a583f54c33c31cd7dca3a84/chrome/browser/previews/previews_browsertest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dougarnett@chromium.org
, Dec 5 2017