We should add coverage to chromium's .vpython spec |
||||
Issue descriptionNow that we have vpython available, we should add the coverage python module to the spec so that we can assume it's available for users and on the bots.
,
Dec 6 2017
Moving into ICC queue so I see this when I start burning down later.
,
Dec 6 2017
https://chromium-review.googlesource.com/c/chromium/src/+/812492 Could probably remove this chunk of code too: https://codesearch.chromium.org/chromium/src/testing/buildbot/PRESUBMIT.py?rcl=9ff5b9c5887d6f7784dadbd10330501e9e27e5d0&l=42
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08eb0fe5d0e990714a4efcc29cb7073824283be5 commit 08eb0fe5d0e990714a4efcc29cb7073824283be5 Author: Benjamin Pastene <bpastene@chromium.org> Date: Thu Dec 07 03:09:33 2017 Add root .vpython spec to analyze's exclusion list. Something that significant should trigger compiles and tests. Bug: 792130 Change-Id: Ia6c467f97e54ac4b8e8b6c6bc8ab00ff4a9acd65 Reviewed-on: https://chromium-review.googlesource.com/812503 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#522324} [modify] https://crrev.com/08eb0fe5d0e990714a4efcc29cb7073824283be5/testing/buildbot/trybot_analyze_config.json
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f88f17c7bd5e60629092fdae5b5a4a33f7c226dd commit f88f17c7bd5e60629092fdae5b5a4a33f7c226dd Author: Benjamin Pastene <bpastene@chromium.org> Date: Thu Dec 07 17:50:32 2017 Add coverage to src's root vpython spec. Looks like we already have the wheel: https://codesearch.chromium.org/chromium/infra/recipes-py/.vpython?rcl=0f093b369402a86363de15a3fae0c98eab4c8e00&l=5 Bug: 792130 Change-Id: I451bc2abe4d801248101536a998f77bba466e6c4 Reviewed-on: https://chromium-review.googlesource.com/812492 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#522466} [modify] https://crrev.com/f88f17c7bd5e60629092fdae5b5a4a33f7c226dd/.vpython
,
Dec 15 2017
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a89036b61de53c4083da98659cfb63c53923784 commit 5a89036b61de53c4083da98659cfb63c53923784 Author: Kenneth Russell <kbr@chromium.org> Date: Thu May 17 22:33:41 2018 Make generate_buildbot_json_coveragetest mandatory. coverage is now part of Chromium's vpython spec. This script is crucial to Chrome's infrastructure, and changes should not be allowed unless the standard of code coverage is maintained. Bug: 843842 , 662541 , 792130 Change-Id: I9164fe331045d13e08c1e1d40c79a01bac368ff9 Reviewed-on: https://chromium-review.googlesource.com/1063257 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559711} [modify] https://crrev.com/5a89036b61de53c4083da98659cfb63c53923784/testing/buildbot/PRESUBMIT.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Dec 5 2017