New issue
Advanced search Search tips

Issue 792126 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

The lockscreen note circle background is a different color on the same wallpaper on html vs views based lockscreen

Project Member Reported by jdufault@chromium.org, Dec 5 2017

Issue description

The lockscreen note circle background is a different color on the same wallpaper on html vs views based lockscreen

 

Comment 1 by shihuis@google.com, Dec 8 2017

Components: UI>Shell>LockScreen
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63080ffcb680430e76247c3ec194f05f2092ff28

commit 63080ffcb680430e76247c3ec194f05f2092ff28
Author: Toni Barzic <tbarzic@google.com>
Date: Mon Dec 18 22:22:44 2017

Fix lock screen note launch button background color

Alpha is the first arg of SkColorSetARGB, not the last (as it was
used in this case). Also, given that the alpha is 0xFF, SkColorSetRGB
can be used instead.

BUG= 792126 

Change-Id: Ib93a9315dae807ec13db412b020f536e5a19d6fe
Reviewed-on: https://chromium-review.googlesource.com/832932
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524834}
[modify] https://crrev.com/63080ffcb680430e76247c3ec194f05f2092ff28/ash/login/ui/note_action_launch_button.cc

Labels: Merge-Request-64
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 5 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can I have some more context as to why this is a P1? Is it blocking functionality, or just cosmetic?


It's cosmetic
Labels: -Merge-Review-64 Merge-Rejected-64
Labels: -M-64 M-65
Status: Fixed (was: Assigned)

Sign in to add a comment