New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792113 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update credentials in .netrc in vm195-m4

Project Member Reported by hnakashima@chromium.org, Dec 5 2017

Issue description

In vm195-m4:

.netrc contains credentials to use for pdfium.googlesource.com, but not for pdfium-review.googlesource.com. Please add credentials for pdfium-review.googlesource.com.

This is necessary so the bots running on this machine can post warning comments to pdfium CLs.
 

Comment 1 by d...@chromium.org, Dec 5 2017

That is not the case:

chrome-bot@vm195-m4:(Linux 14.04):~$ ls -ltra .netrc
-rw------- 1 chrome-bot chrome-bot 1620 Nov 29 15:22 .netrc
chrome-bot@vm195-m4:(Linux 14.04):~$ grep 'pdf' .netrc | awk '{ print $1 " " $2 }'
machine pdfium.googlesource.com
machine pdfium-review.googlesource.com
Status: WontFix (was: Untriaged)
Oh, it was probably already fixed by Sana (cc'ed) then. Thank you.

Closing as WAI.

Comment 3 by s...@google.com, Dec 6 2017

Status: Untriaged (was: WontFix)
I made the change manually on the bot last week:
-rw------- 1 chrome-bot chrome-bot 1620 Nov 29 15:22 .netrc

Shouldn't this be properly fixed in Puppet? I'm surprised Puppet hasn't overwritten this bot's .netrc yet.

Comment 4 by d...@chromium.org, Dec 6 2017

Owner: d...@chromium.org
Status: Assigned (was: Untriaged)
> Shouldn't this be properly fixed in Puppet? I'm surprised Puppet hasn't overwritten this bot's .netrc yet.

Shouldn't you have fixed it properly then? :)

Comment 5 by d...@chromium.org, Dec 6 2017

Is vm195-m4 the only bot which needs these credentials?
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/b7ad5acd86783bc27fac4dfc3c86ed24b5a2a06d

commit b7ad5acd86783bc27fac4dfc3c86ed24b5a2a06d
Author: Bryce Albritton <dba@google.com>
Date: Wed Dec 06 18:34:03 2017

Comment 7 by d...@chromium.org, Dec 6 2017

Went ahead and targeted all bots on tryserver.client.pdfium. vm195-m4 now has an updated puppet managed netrc with the credentials:

chrome-bot@vm195-m4:(Linux 14.04):~$ cat .netrc | grep -E 'puppet|^machine pdf' | wc -l
3

Marking as fixed. Reopen if that's not the case.

Comment 8 by d...@chromium.org, Dec 6 2017

Status: Fixed (was: Assigned)
Yeah, all bots should need it - it's just the vm195-m4 was the only one that didn't have it already.

Thank you!

Sign in to add a comment