New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792098 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug-Regression
Proj-VR
Proj-XR



Sign in to add a comment

Android ASan build is crashing on startup

Project Member Reported by mmoroz@chromium.org, Dec 5 2017

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/790971 seems to be a culprit

No implementation found for void org.chromium.chrome.browser.vr_shell.VrShellDelegate.nativeOnChromeStarted() (tried Java_org_chromium_chrome_browser_vr_1shell_VrShellDelegate_nativeOnChromeStarted and Java_org_chromium_chrome_browser_vr_1shell_VrShellDelegate_nativeOnChromeStarted__)
FATAL EXCEPTION: main
Process: com.google.android.apps.chrome, PID: 5854
java.lang.UnsatisfiedLinkError: No implementation found for void org.chromium.chrome.browser.vr_shell.VrShellDelegate.nativeOnChromeStarted() (tried Java_org_chromium_chrome_browser_vr_1shell_VrShellDelegate_nativeOnChromeStarted and Java_org_chromium_chrome_browser_vr_1shell_VrShellDelegate_nativeOnChromeStarted__)
at org.chromium.chrome.browser.vr_shell.VrShellDelegate.nativeOnChromeStarted(Native Method)
at org.chromium.chrome.browser.vr_shell.VrShellDelegate.maybeRegisterVrEntryHook(VrShellDelegate.java:27)
at org.chromium.chrome.browser.ChromeActivity.onResumeWithNative(ChromeActivity.java:482)
at org.chromium.chrome.browser.ChromeTabbedActivity.onResumeWithNative(ChromeTabbedActivity.java:194)
at org.chromium.chrome.browser.init.NativeInitializationController.onResume(NativeInitializationController.java:18)
at org.chromium.chrome.browser.init.AsyncInitializationActivity.finishNativeInitialization(AsyncInitializationActivity.java:81)
at org.chromium.chrome.browser.ChromeActivity.finishNativeInitialization(ChromeActivity.java:735)
at org.chromium.chrome.browser.ChromeTabbedActivity.finishNativeInitialization(ChromeTabbedActivity.java:190)
at org.chromium.chrome.browser.init.ChromeBrowserInitializer$9.run(ChromeBrowserInitializer.java:3)
at org.chromium.chrome.browser.init.ChainedTasks$1.run(ChainedTasks.java:7)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
 
More precisely: android_asan_chrome_x86 (r459879)

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8828640718df11677493bfaf7cb8e77a13780f4a

commit 8828640718df11677493bfaf7cb8e77a13780f4a
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Dec 05 20:46:09 2017

[vr] Fix startup crash on platforms not supporting VR

Bug:  792098 
Change-Id: If75e986571a3490c4d70e22a4748e43b517ba857
Reviewed-on: https://chromium-review.googlesource.com/809099
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521821}
[modify] https://crrev.com/8828640718df11677493bfaf7cb8e77a13780f4a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Assigned)
Should be fixed.
Labels: -Type-Bug M-65 Arch-x86 OS-Android Type-Bug-Regression
Thank you Tibor!
Issue 791876 has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 11 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1358709e49efe8827f24635f2dc8a3da74cfded0

commit 1358709e49efe8827f24635f2dc8a3da74cfded0
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Mon Dec 11 18:52:06 2017

[vr] Fix startup crash on platforms not supporting VR

Bug:  792098 
Change-Id: If75e986571a3490c4d70e22a4748e43b517ba857
Reviewed-on: https://chromium-review.googlesource.com/809099
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521821}(cherry picked from commit 8828640718df11677493bfaf7cb8e77a13780f4a)
Reviewed-on: https://chromium-review.googlesource.com/820430
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#138}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/1358709e49efe8827f24635f2dc8a3da74cfded0/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment