New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792090 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 792080
Owner: ----
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

33.8%-35.3% regression in blink_perf.shadow_dom at 521229:521251

Project Member Reported by pmeenan@chromium.org, Dec 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=792090

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=73a36faecf969512d11159a0f7e04e0c55e34925151de2bf26fc5e297794a94a


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Mergedinto: 792080
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Naina Raisinghani
  Commit : b71f5b7df345f1a8603b7cf7b59edf48288e7d96
  Date   : Mon Dec 04 01:01:29 2017
  Subject: Remove calls to styleForLayoutObject() in LayoutTreeBuilder::style()

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.shadow_dom
  Metric       : v1-large-deep-layout/v1-large-deep-layout
  Change       : 36.74% | 18735.285 -> 25617.8436667

Revision             Result                  N
chromium@521228      18735.3 +- 100.719      6      good
chromium@521234      18882.7 +- 48.5705      6      good
chromium@521237      18707.1 +- 127.849      6      good
chromium@521239      18793.1 +- 156.911      6      good
chromium@521240      25648.3 +- 201.123      6      bad       <--
chromium@521251      25617.8 +- 125.22       6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961032289108854400


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment