Components are unzipped in the browser process - servicify the unzipper and do it out of process.
(This is needed to make update_client capable of doing extension updates, which have to be handled OOP.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d19ee7988a3f97118f3ff791acf77f3eeed891c commit 5d19ee7988a3f97118f3ff791acf77f3eeed891c Author: Joshua Pawlicki <waffles@google.com> Date: Tue Feb 06 20:24:51 2018 Change unzipping library to support cross-process delegates. This prepares for servicification of the unzipping library, where the library will not have direct access to the filesystem. Bug: 792066 Change-Id: I696dd8ef0936f22dc637e078bd8bba565e854ead Reviewed-on: https://chromium-review.googlesource.com/860996 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Satoru Takabayashi <satorux@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534778} [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/chrome/services/file_util/public/cpp/zip_file_creator_browsertest.cc [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/third_party/zlib/google/zip.cc [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/third_party/zlib/google/zip.h [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/third_party/zlib/google/zip_reader.cc [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/third_party/zlib/google/zip_reader.h [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/third_party/zlib/google/zip_reader_unittest.cc [modify] https://crrev.com/5d19ee7988a3f97118f3ff791acf77f3eeed891c/third_party/zlib/google/zip_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d76442a2acad95257d7beb62be7691f73f014c0 commit 6d76442a2acad95257d7beb62be7691f73f014c0 Author: Joshua Pawlicki <waffles@google.com> Date: Wed Feb 21 15:23:10 2018 Servicify unzipping and use it in the component updater. Bug: 792066 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I910f5dde8cb7c071c4aeb6e3a0db04b301db1063 Reviewed-on: https://chromium-review.googlesource.com/809264 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#538109} [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/app/BUILD.gn [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/app/generated_resources.grd [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/browser/BUILD.gn [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/utility/BUILD.gn [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/utility/DEPS [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/component_updater/component_installer_unittest.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/filesystem/public/interfaces/types.mojom [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/BUILD.gn [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/DEPS [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/OWNERS [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/manifest.json [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/cpp/BUILD.gn [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/cpp/unzip.cc [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/cpp/unzip.h [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/interfaces/BUILD.gn [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/interfaces/OWNERS [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/interfaces/README.md [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/interfaces/constants.mojom [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/public/interfaces/unzipper.mojom [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/unzip_service.cc [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/unzip_service.h [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/unzipper_impl.cc [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/unzip_service/unzipper_impl.h [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/BUILD.gn [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/DEPS [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/action_runner.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/action_runner.h [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/component_unpacker.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/component_unpacker.h [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/component_unpacker_unittest.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/test_configurator.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/test_configurator.h [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/components/update_client/update_client_unittest.cc [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/chrome_browser_manifest_overlay.json [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/unzip/BUILD.gn [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/unzip/DEPS [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/unzip/OWNERS [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/unzip/unzip_service_creator.cc [add] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/unzip/unzip_service_creator.h [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/web/chrome_web_client.h [modify] https://crrev.com/6d76442a2acad95257d7beb62be7691f73f014c0/ios/chrome/browser/web/chrome_web_client.mm
Comment 1 by waff...@chromium.org
, Jan 5 2018