New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792061 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 790691
Owner: ----
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 757440



Sign in to add a comment

11.1%-87.2% regression in blink_perf.dom at 519768:520267

Project Member Reported by pmeenan@chromium.org, Dec 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=792061

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fd2157aff74f62d62ff94ea95eabbf8cecbf19ac72b1fd475c4ef9836d62166a


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus6
android-nexus7v2
android-one
android-webview-nexus6
chromium-rel-mac11-pro
chromium-rel-win10
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win8-dual

=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : blink_perf.dom
  Metric       : move-down-with-hidden-elements/move-down-with-hidden-elements
  Change       : 33.05% | 1.42716666667 -> 1.89883333333

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/4f59a790e19f97e8bbdbb6e7960883c1e1cf0234..c47b4d110a697afa6a6ee4d4748028312c65ec19


Revision             Result                    N
chromium@520047      1.42717 +- 0.295447       6        good
chromium@520055      1.67167 +- 0.607          6        good
chromium@520060      1.587 +- 0.0672309        6        good
chromium@520061      ---                       ---      build failure
chromium@520062      2.44233 +- 0.204003       6        bad
chromium@520063      2.4525 +- 0.216327        6        bad
chromium@520078      2.28633 +- 0.137751       6        bad
chromium@520107      1.89883 +- 0.0833477      6        bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961033117093237184


For feedback, file a bug with component Speed>Bisection
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
mlippautz@ could you PTAL and see if this makes any sense?  The "[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag" change is a lot more likely to be the culprit than the webrtc change (if the bisect narrowed correctly).
Blocking: 757440
Thanks for triaging. Yes, that makes sense.

In fact,  I was expecting those regressions and surprised that nothing bubbled through so far.
 Issue 791993  has been merged into this issue.
Mergedinto: 790691
Status: Duplicate (was: Assigned)
Status: Fixed (was: Duplicate)
Unmerging to be able to to prioritize correctly.

I landed an optimization that reduces the cases where we need to execute a write barrier in faf0c6646d65d165018b9af7331033b4c358e7ba.

I see that  issue 792444  was closed because the bisect didn't work and the graphs recovered. In fact, the recovered because of the CL mentioned above.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 25 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14c095ec840000
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jan 25 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14a7b5ec840000

Comment 11 by yosin@chromium.org, Jan 26 2018

Cc: yosin@chromium.org
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jan 27 2018

Cc: falken@chromium.org mlippautz@chromium.org dcheng@chromium.org kinuko@chromium.org yhirano@chromium.org haraken@chromium.org mek@chromium.org mmenke@chromium.org
Status: Assigned (was: Fixed)
๐Ÿ“ Found significant differences after each of 2 commits.
https://pinpoint.chromeperf.appspot.com/job/14c095ec840000

service worker: Remove foreign fetch and link registration.
By falken@chromium.org ยท Wed Nov 29 08:11:42 2017
chromium @ f497cf3c009d1e74c52910bd182ac4b5944c2b51

[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag
By mlippautz@chromium.org ยท Wed Nov 29 10:09:43 2017
chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
That pinpoint link is showing a cert error....

Comment 14 by yosin@chromium.org, Jan 31 2018

Owner: ----
Status: Fixed (was: Assigned)
Mark Fixed as #c11.
mlippautz@, pointed in #c12, had already addressed this issue.

Sign in to add a comment