Issue metadata
Sign in to add a comment
|
11.1%-87.2% regression in blink_perf.dom at 519768:520267 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 5 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8961033117093237184
,
Dec 5 2017
=== BISECT JOB RESULTS === Perf regression found but unable to narrow commit range Build failures prevented the bisect from narrowing the range further. Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : blink_perf.dom Metric : move-down-with-hidden-elements/move-down-with-hidden-elements Change : 33.05% | 1.42716666667 -> 1.89883333333 Suspected Commit Range 2 commits in range https://chromium.googlesource.com/chromium/src/+log/4f59a790e19f97e8bbdbb6e7960883c1e1cf0234..c47b4d110a697afa6a6ee4d4748028312c65ec19 Revision Result N chromium@520047 1.42717 +- 0.295447 6 good chromium@520055 1.67167 +- 0.607 6 good chromium@520060 1.587 +- 0.0672309 6 good chromium@520061 --- --- build failure chromium@520062 2.44233 +- 0.204003 6 bad chromium@520063 2.4525 +- 0.216327 6 bad chromium@520078 2.28633 +- 0.137751 6 bad chromium@520107 1.89883 +- 0.0833477 6 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8961033117093237184 For feedback, file a bug with component Speed>Bisection
,
Dec 5 2017
mlippautz@ could you PTAL and see if this makes any sense? The "[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag" change is a lot more likely to be the culprit than the webrtc change (if the bisect narrowed correctly).
,
Dec 6 2017
Thanks for triaging. Yes, that makes sense. In fact, I was expecting those regressions and surprised that nothing bubbled through so far.
,
Dec 6 2017
Issue 791993 has been merged into this issue.
,
Dec 6 2017
,
Dec 11 2017
Unmerging to be able to to prioritize correctly. I landed an optimization that reduces the cases where we need to execute a write barrier in faf0c6646d65d165018b9af7331033b4c358e7ba. I see that issue 792444 was closed because the bisect didn't work and the graphs recovered. In fact, the recovered because of the CL mentioned above.
,
Jan 25 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14c095ec840000
,
Jan 25 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a7b5ec840000
,
Jan 26 2018
,
Jan 27 2018
๐ Found significant differences after each of 2 commits. https://pinpoint.chromeperf.appspot.com/job/14c095ec840000 service worker: Remove foreign fetch and link registration. By falken@chromium.org ยท Wed Nov 29 08:11:42 2017 chromium @ f497cf3c009d1e74c52910bd182ac4b5944c2b51 [oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag By mlippautz@chromium.org ยท Wed Nov 29 10:09:43 2017 chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 27 2018
That pinpoint link is showing a cert error....
,
Jan 31 2018
Mark Fixed as #c11. mlippautz@, pointed in #c12, had already addressed this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 5 2017