New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 757440



Sign in to add a comment

12.9%-21.2% regression in blink_perf.bindings at 520007:520369

Project Member Reported by pmeenan@chromium.org, Dec 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=792060

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f183b99a899137baae3bc519b9ffb3dbbe5be8c7e213446d446960f2154e5973


Bot(s) for this bug's original alert(s):

android-nexus5X
android-one
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-win10
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia

=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : insert-before/insert-before


Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961033140264558720


For feedback, file a bug with component Speed>Bisection
Cc: kylec...@chromium.org dcheng@chromium.org piman@chromium.org danakj@chromium.org emir...@chromium.org magjed@chromium.org haraken@chromium.org mlippautz@chromium.org
Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/1598ee44040000

[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag
By mlippautz@chromium.org · Wed Nov 29 10:09:43 2017
chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7

WebRTC: Migrate completely to new video codec factories API
By magjed@chromium.org · Wed Nov 29 10:21:53 2017
chromium @ c47b4d110a697afa6a6ee4d4748028312c65ec19

Add a forwarding CompositingModeReporter to the browser for viz
By danakj@chromium.org · Wed Nov 29 16:19:43 2017
chromium @ 4ee301ce3b1c20628c005f327a219b02be3484c7

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: mlippautz@chromium.org
> [oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag
> By mlippautz@chromium.org · Wed Nov 29 10:09:43 2017
> chromium @ 5f56deb44521c891ed8093cadd3ba8cc52a168a7

I guess the culprit would be this one.


Blocking: 757440
Components: Blink>MemoryAllocator>GarbageCollection
Status: Fixed (was: Assigned)
The regressions have mostly recovered with my CL in [1]. There's a small gap left which is due the inherent nature of a write barrier intercepting writes.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/812344

Sign in to add a comment