New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792058 link

Starred by 1 user
Status: WontFix
Owner:
mlippautz@chromium.org
Closed: Dec 2017
Cc:
█ pmeenan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 757440



Sign in to add a comment

0.6%-0.8% regression in sizes at 520061:520061

Project Member Reported by pmeenan@chromium.org, Dec 5 2017 
It looks like the removal of the heap marking flag increased the binary size by ~1MB. Was that expected?
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 5 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=792058

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a5cb8fc170046a4806d3a02c6e79fd155d4d61e46be20f6280574561bdeae9fd


Bot(s) for this bug's original alert(s):

mac
win
win-32

Comment 2 by mlippautz@chromium.org, Dec 5 2017 

Yes, sort of.  Issue 789637  is related.

The short version is that this is core garbage collection infra structure that adds to each write. I am now trying to optimize and reduce the cases where we need this.

Keeping open and assigned to me as I am still experimenting with trade offs.

Comment 3 by mlippautz@chromium.org, Dec 5 2017

Blocking: 757440

Comment 4 by mlippautz@chromium.org, Dec 8 2017

Status: WontFix (was: Assigned)
faf0c6646d65d165018b9af7331033b4c358e7ba gets back ~280k. We are aware of the increase of binary size and will prioritize accordingly. 

Since this is core garbage collection infrastructure of the renderer, I think the increase is justified.

WontFix, with a partial fix.
►

Sign in to add a comment