New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792029 link

Starred by 2 users
Status: Assigned
Owner:
eyaich@chromium.org
Cc:
simonhatch@chromium.org
█ nednguyen@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

test-results upload failures on chromium.perf waterfall for disabled tests

Project Member Reported by eyaich@chromium.org, Dec 5 2017 
Specifically this is on Mac 10.11. Step 140 here:

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%2010.11%20Perf/builds/1533


I am not getting much debug info. Here is the link to the logs and a stack trace.  

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_10.11_Perf%2F1533%2F%2B%2Frecipes%2Fsteps%2FUpload_to_test-results__dummy_benchmark.histogram_benchmark_1.reference_on_Intel_GPU_on_Mac_%2F0%2Fstdout

Is this something with histogram set?

Interestingly the main waterfall is showing errors with no associated tests, I haven't looked at them all since if the upload fails it should state that on the main page.  Maybe somethign wrong with the recipe?  I can file a separate bug for that if you prefer.

https://uberchromegw.corp.google.com/i/chromium.perf/waterfall

"failed steps failed failure reason" is all it displays on the main page.

Comment 1 by simonhatch@chromium.org, Dec 5 2017 

So first, upload to test-results is the flakiness dashboard right?

Also, it looks like it's not specific to histograms. There's also smoothness.gpu_rasterization.polymer that has the same issue, kinda looks like it's just disabled tests in general. The error has the following:

test_results_uploader.PermanentError: Received HTTP status 400 loading "https://test-results.appspot.com/testfile/upload": uploaded file is missing required num_failures_by_type field

So maybe disabled tests don't generate the proper json for upload or something?

Comment 2 by eyaich@chromium.org, Dec 5 2017

Cc: -eyaich@chromium.org nednguyen@chromium.org
Owner: eyaich@chromium.org
Summary: test-results upload failures on chromium.perf waterfall for disabled tests (was: upload failures on chromium.perf waterfall)
ah thank you for the clarification!  I missed that.  I looked at upload and made an inaccurate assumption, it is test results.  

I agree that it seems to only be on disabled benchmarks, although right now it is passing.  

I think there are two separate issues here: 

1) uploading failing for disabled tests
2) buildbot page not correctly reflecting those

I am not as familiar with the flakiness upload code.  I included Ned since I think he implemented that part of the recipe code or he can redirect us to who did.  

Removing Ethan since this doesn't seem related to histogram set.
►

Sign in to add a comment