New issue
Advanced search Search tips

Issue 791985 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 818381



Sign in to add a comment

Disable notifications from Windows/MS on Win10 bots - MenuViewDragAndDropTestTestInMenuDrag flaky

Project Member Reported by grt@chromium.org, Dec 5 2017

Issue description

I see failures like this on the "Win 10 Fast Ring" bot:

[ RUN      ] BookmarkBarViewTest4.ContextMenus
[5732:7192:1205/014740.349:12421140:ERROR:interactive_test_utils_win.cc(67)] ShowAndFocusNativeWindow failed. foreground window: 00000000000101B4, title: New notification, path: C:\Windows\SystemApps\ShellExperienceHost_cw5n1h2txyewy\ShellExperienceHost.exe
../../chrome/test/base/view_event_test_base.cc(147): error: Value of: ui_test_utils::ShowAndFocusNativeWindow(window_->GetNativeWindow())
  Actual: false
Expected: true
[  FAILED  ] BookmarkBarViewTest4.ContextMenus (61 ms)

I believe (but haven't confirmed) that the "New notification" window is a toast/popup from Windows/Microsoft on the desktop. If I'm correct, it's messing with interactive_ui_tests. To keep us sane, it would be good to disable any/all desktop notifications on Win10 bots so that they don't lead to random flakes here and there.

We could also investigate making the always_on_top_window_killer know how to close these. This would be a band-aid at best, though, since they could still appear during a test run.

Tentatively assigning to wfh@, whom I believe was working on getting these bots up.
 
Components: -Infra Infra>Client>Chrome
Encountered this here: https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/97693

[4164:6812:0308/142324.265:ERROR:interactive_test_utils_win.cc(67)] ShowAndFocusNativeWindow failed. foreground window: 00000000030402AE, title: Important updates are pending, path: C:\Windows\System32\MusNotificationUx.exe

Comment 3 by grt@chromium.org, Mar 9 2018

Cc: wfh@chromium.org
Labels: Infra-Troopers
Owner: ----
Status: Available (was: Assigned)
Marking this as available and adding Infra-Troopers in the hopes that a trooper will look at it. It seems that win10-0ab1efdf-us-west1-c-hlcl (and likely other bots) was showing a Windows notification about an update. Is it possible to use Group Policy to disable these notifications on the bots?

Comment 4 by grt@chromium.org, Mar 12 2018

Cc: grt@chromium.org
 Issue 820714  has been merged into this issue.
grt: what did update notification look like?

we started seeing update issues last week over in issue 819355; perhaps that's related?

Comment 6 by grt@chromium.org, Mar 12 2018

I don't have a screenshot, but the tests are failing because a window opened by C:\Windows\System32\MusNotificationUx.exe with the title "Important updates are pending" is getting in the way.

Maybe https://docs.microsoft.com/en-us/windows/deployment/update/waas-restart#control-restart-notifications has info on how to disable these?
Blockedon: 818381
Ah. We're not on 1703 yet; doing so is issue 818381.

Comment 8 by hinoka@chromium.org, Mar 14 2018

Components: Infra>Labs
Labels: -Infra-Troopers -Pri-3 Pri-2
I have a test for this building now.  Are there specific bots/builders that need this applied?  All of tryserver.chromium.win?  Can we test it somehow?  How would you like it rolled out?
Owner: friedman@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/5ceb9958ce019921d88a2db06887f4a96aa663f2

commit 5ceb9958ce019921d88a2db06887f4a96aa663f2
Author: Elliott Friedman <friedman@google.com>
Date: Thu Apr 19 00:18:27 2018

Comment 12 by grt@chromium.org, Apr 19 2018

Awesome! Thanks. This should help reduce flakes in interactive_ui_tests and friends.
Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, Apr 20 2018

Labels: Sheriff-Chromium
Detected 25 new flakes for test/step "MenuViewDragAndDropTestTestInMenuDrag.TestInMenuDrag". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRNZW51Vmlld0RyYWdBbmREcm9wVGVzdFRlc3RJbk1lbnVEcmFnLlRlc3RJbk1lbnVEcmFnDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Summary: Disable notifications from Windows/MS on Win10 bots - MenuViewDragAndDropTestTestInMenuDrag flaky (was: Disable notifications from Windows/MS on Win10 bots)
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/a19baf6d9ef1f9f2e5184079b18b39d27d8188f2

commit a19baf6d9ef1f9f2e5184079b18b39d27d8188f2
Author: Elliott Friedman <friedman@google.com>
Date: Fri Apr 20 19:45:45 2018

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/923c759315f8a8e6180c1603929437f974281455

commit 923c759315f8a8e6180c1603929437f974281455
Author: Elliott Friedman <friedman@google.com>
Date: Fri Apr 20 19:51:37 2018

Project Member

Comment 17 by chromium...@appspot.gserviceaccount.com, Apr 21 2018

Detected 3 new flakes for test/step "MenuViewDragAndDropTestTestInMenuDrag.TestInMenuDrag". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRNZW51Vmlld0RyYWdBbmREcm9wVGVzdFRlc3RJbk1lbnVEcmFnLlRlc3RJbk1lbnVEcmFnDA. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/b285fd87377599b92863028083635a841099d4cb

commit b285fd87377599b92863028083635a841099d4cb
Author: Elliott Friedman <friedman@google.com>
Date: Tue Apr 24 17:25:42 2018

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b1edff32993827fd05109f8b75fbd68f4606e8e3

commit b1edff32993827fd05109f8b75fbd68f4606e8e3
Author: Elliott Friedman <friedman@google.com>
Date: Tue Apr 24 17:28:39 2018

Status: Fixed (was: Assigned)
I assume this is fixed.

Sign in to add a comment