Issue metadata
Sign in to add a comment
|
Text goes off the screen while entering bookmark folder title |
||||||||||||||||||||||
Issue descriptionApp Version: 65.0.3285.0 Canary iOS Version: 10.3.3 only Device: iPhone and iPad Steps to reproduce: 1. Launch chrome 2. Open bookmarks and select mobile bookmarks folder 3. Tap on the new folder button 4. Enter a text like ‘List of mountains’ Observed results: Notice while entering text the initially entered text will goes gradually of the screen Note: In iOS 11 the text will goes of the screen only when text is completely full in the bookmark folder cell Expected results: The text shouldn't go off the screen until the text entered is cell is full. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M62 & M63 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M64 Link to video/image: M65 behavior: https://drive.google.com/a/google.com/file/d/1frmHRwtR78SgKMVSXLlQW63u8UPjGtEV/view?usp=sharing M63 stable behavior: https://drive.google.com/a/google.com/file/d/14tEyb3G1Fm_MZ1ISLRR_a5fd07NUGJFq/view?usp=sharing
,
Dec 6 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dca51d2749b77c0f89d5be74a2f5feb060e5ce9 commit 9dca51d2749b77c0f89d5be74a2f5feb060e5ce9 Author: Marti Wong <martiw@chromium.org> Date: Wed Dec 06 12:25:04 2017 Fix the cell layout issue when creating new folder (iOS bookmarks) Make the trailingAnchor of the stackView inside bookmarkTableCell always equals to contentView's trailingAnchor. This can prevent crbug.com/778231 where the stackView's width doesn't grow as expected when editing folder name on iOS 10. Bug: 791976 Change-Id: I71fac7e335561fe7f54beb1062602976b0b2a280 Reviewed-on: https://chromium-review.googlesource.com/809988 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#522071} [modify] https://crrev.com/9dca51d2749b77c0f89d5be74a2f5feb060e5ce9/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm
,
Dec 7 2017
,
Dec 8 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5216af1ba68ecf909f54b273faae31a7a00b407 commit f5216af1ba68ecf909f54b273faae31a7a00b407 Author: Marti Wong <martiw@chromium.org> Date: Mon Dec 11 00:56:56 2017 Fix the cell layout issue when creating new folder (iOS bookmarks) Make the trailingAnchor of the stackView inside bookmarkTableCell always equals to contentView's trailingAnchor. This can prevent crbug.com/778231 where the stackView's width doesn't grow as expected when editing folder name on iOS 10. Bug: 791976 Change-Id: I71fac7e335561fe7f54beb1062602976b0b2a280 Reviewed-on: https://chromium-review.googlesource.com/809988 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522071}(cherry picked from commit 9dca51d2749b77c0f89d5be74a2f5feb060e5ce9) Reviewed-on: https://chromium-review.googlesource.com/817715 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#117} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/f5216af1ba68ecf909f54b273faae31a7a00b407/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm
,
Dec 11 2017
,
Dec 12 2017
Verified on M65.0.3292.0 canary iPhone7 plus, iOS10.3.3 Text displayed correctly when entering the long title for a bookmark folder.
,
Dec 13 2017
Verified on M64.0.3282.26 Beta on iPhone 7(iOS 10.3.3) and iPad Air(iOS 10.3.3) On entering long title in bookmark folder the text displays correctly |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by martiw@chromium.org
, Dec 6 2017Status: Started (was: Untriaged)