New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791974 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

copy as curl should not return text starting at `blob:`

Reported by piotr.sr...@brainhub.pl, Dec 5 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
- I have an audio request
- I open Network tab
- I find the request
- I open context menu at the request
- I click Copy->Copy as cUrl
- I paste the copied cUrl in the terminal
- I obtain `curl: (6) Could not resolve host: blob:https`

What is the expected behavior?
It should copy a valid cURL which returns 206 status code

What went wrong?
It copied:
```
curl 'blob:https://url-of-my-site.com/some-path' -H 'Accept-Encoding: identity;q=1, *;q=0' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36' -H 'Range: bytes=0-' -H 'chrome-proxy: frfr'
```

but is should copy without `blob:` at the begin so:
```
curl 'https://url-of-my-site.com/some-path' -H 'Accept-Encoding: identity;q=1, *;q=0' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36' -H 'Range: bytes=0-' -H 'chrome-proxy: frfr'
```

Did this work before? N/A 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: OS X 10.12.2
Flash Version:
 
Cc: vamshi.k...@techmahindra.com
Labels: Neeeds-Triage-M62 Triaged-ET Needs-Feedback
"Thanks for filing the issue.

@Reporter: Could you please share a sample test file/URL to check the issue from TE end. Any further inputs from your side helps us to triage the issue in a better way."
Components: -Platform>DevTools Platform>DevTools>Network
Owner: chenwilliam@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: copy as curl should not return text starting at `blob:` (was: copy as curl shout not return text starting at `blob:`)
Owner: eostroukhov@chromium.org

Comment 5 by phistuck@gmail.com, Mar 17 2018

Is this still reproducible?

Does the Network panel show that the request URL is "blob:..." for that request, or is "blob:" only prepended when copying as cURL?

For the former, I think any "Copy as..." should not appear for blob: requests at all (and those URLs should be excluded from the "Copy all as..." version as well) as their URLs are meaningless in any other context.

For the latter, can you provide a URL that reproduces the issue?
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f01cef6311ea3b4087822419d321cc50bd498ebc

commit f01cef6311ea3b4087822419d321cc50bd498ebc
Author: Harley Li <hhli@chromium.org>
Date: Mon Sep 10 18:01:13 2018

[DevTools] Disable copy as options for blob network requests

Blob requests do not make sense when running outside
of the page which created them, so generating a cURL command
would be misleading.

Bug:  791974 
Change-Id: Ica9295d4e9f1cced9fd47b78a5338f68f71e5373
Reviewed-on: https://chromium-review.googlesource.com/1213825
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589976}
[modify] https://crrev.com/f01cef6311ea3b4087822419d321cc50bd498ebc/third_party/WebKit/LayoutTests/http/tests/devtools/copy-network-request-expected.txt
[modify] https://crrev.com/f01cef6311ea3b4087822419d321cc50bd498ebc/third_party/WebKit/LayoutTests/http/tests/devtools/copy-network-request.js
[modify] https://crrev.com/f01cef6311ea3b4087822419d321cc50bd498ebc/third_party/blink/renderer/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/f01cef6311ea3b4087822419d321cc50bd498ebc/third_party/blink/renderer/devtools/front_end/sdk/NetworkRequest.js

Owner: hhli@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment