New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791959 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Delay is seen in appearing of ghost text in Ubertray's 'Bluetooth disabled'

Project Member Reported by kebalaji@chromium.org, Dec 5 2017

Issue description

CChrome Version:64.0. 3282.7/10176.4.0 Kip,Reks,Daisy
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Click on Ubertray and on Bluetooth disabled
(2)Observe the Ghost text

Actual: Delay is seen in apeeraing ghost text
Expected: No delay should be seen 

This is a Regression issue as same is working fine in 64.0.3280.5/10187.0.0 dev 

Note:Issue is not seen in Windows,Linux OS

@tbuckley: Please confirm the issue.

 
ActualDelay.mp4
3.2 MB View Download
ExpectedDelay.mp4
2.6 MB View Download
Cc: omrilio@chromium.org tbuck...@chromium.org
Owner: zork@chromium.org
+zork can someone look at this?

+omrilio as FYI for bluetooth
Cc: r...@chromium.org
M64 beta is targeted for next Tuesday (12-Dec); anything we can do to close this out and/or retag as stable block is appreciated.   I'll ping the owner as well.  Thanks!

Comment 4 by zork@chromium.org, Dec 7 2017

Cc: zork@chromium.org
Owner: x...@chromium.org
Daisy, could you have someone look into this?

Comment 5 by x...@chromium.org, Dec 8 2017

Cc: x...@chromium.org
Owner: minch@chromium.org
minch@, could you take a quick look at it to see if there is a quick fix for this? Otherwise we might consider to change it to RBS.

Comment 6 by minch@chromium.org, Dec 8 2017

Cc: xiaoyinh@chromium.org
Sarah, seems that you did some refactoring of the bluetooth view recently, do you know the cause of this?
Owner: xiaoyinh@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/765014 change the update frequency of the bluetooth tray. 
I will work on a fix for this.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9044641b5a73aea7da5c3f9cbf769facc6af7862

commit 9044641b5a73aea7da5c3f9cbf769facc6af7862
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Fri Dec 08 23:57:13 2017

Update bluetooth tray immediately when bluetooth is disabled.

Update the tray for the initial device list or when the bluetooth is disabled.

Bug:  791959 
Change-Id: I2cbe3611edada33c2ef7794aad3785cc36ef711f
Reviewed-on: https://chromium-review.googlesource.com/818322
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522925}
[modify] https://crrev.com/9044641b5a73aea7da5c3f9cbf769facc6af7862/ash/system/bluetooth/tray_bluetooth.cc

Labels: Merge-Request-64
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 10 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please re-evaluate today (Monday, 11-Dec) re: Beta Blocker Status.  We're targeting Beta for tomorrow, so please update if a) this isn't blocking, b) the impacted boards can be identified, c) this is resolve / not reproducible, d) a merge / fix can be submitted today.

Assume the submitted CL should address?  If so please mark as fixed asap.  And if you know the rev where the CL landed.

Thanks
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 11 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/501c649b3b6f40d32c3eda52e83a2bd0a8c41e0b

commit 501c649b3b6f40d32c3eda52e83a2bd0a8c41e0b
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Dec 11 18:50:40 2017

[Merge to M64]Update bluetooth tray immediately when bluetooth is disabled.

Update the tray for the initial device list or when the bluetooth is disabled.

(cherry picked from commit 9044641b5a73aea7da5c3f9cbf769facc6af7862)

TBR: stevenjb@chromium.org
Bug:  791959 
Change-Id: I2cbe3611edada33c2ef7794aad3785cc36ef711f
Reviewed-on: https://chromium-review.googlesource.com/818322
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522925}
Reviewed-on: https://chromium-review.googlesource.com/820331
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#135}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/501c649b3b6f40d32c3eda52e83a2bd0a8c41e0b/ash/system/bluetooth/tray_bluetooth.cc

Status: Fixed (was: Assigned)
 Issue 793745  has been merged into this issue.

Sign in to add a comment