Issue metadata
Sign in to add a comment
|
Regression: Buttons are not clickable in Proxy overlay of OOBE screen |
||||||||||||||||||||||
Issue descriptionCChrome Version:64.0. 3282.7/10176.4.0 Kip,Reks,Daisy OS:Chrome OS What steps will reproduce the problem? (1)Recover build>> In OOBE screen, Connect to Network overlay, give wrong password for some connection (2)Click on the error notification and observe the proxy overlay Actual: Dropdown, close button, radio buttons, toggle button are not working Expected: Everthing should work as usual. This is a Regression issue as same is working fine in 64.0.3280.5/10187.0.0 dev Note:Issue is not seen in Windows,Linux OS @alemate: Please confirm the issue.
,
Dec 11 2017
Please re-evaluate today (Monday, 11-Dec) re: Beta Blocker Status. We're targeting Beta for tomorrow, so please update if a) this isn't blocking, b) the impacted boards can be identified, c) this is resolve / not reproducible, d) a merge / fix can be submitted today. Thanks!
,
Dec 12 2017
Punting this to RBS. Only happens during OOBE flow and when wrong password is input. But we should def get this fixed before shipping stable.
,
Dec 12 2017
,
Dec 13 2017
I see two separate issues here: 1) The Web UI no longer gets input. 2 The dialog is wrong (it must be WiFi password dialog, you can do nothing in this situation with the dialog shown). Assigning to Steven, who did latest changes in this code.
,
Dec 13 2017
,
Dec 13 2017
I filed a separate issue for the incorrect dialog.
,
Dec 13 2017
The problem appears to be related to having both dialogs open at once. I can investigate that. Opening the settings dialog instead of the configure dialog is intentional if we think the network is configured, but we can be doing a better job of figuring out which dialog to open, I'll address that in the other issue.
,
Dec 13 2017
,
Dec 13 2017
OK, this is an oshima@ issue :) oshima@ - here is where we open the network settings dialog: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.cc?q=system_web_dialog&sq=package:chromium&l=65 The new dialog is opened over the existing modal dialog, but it does not receive focus. This can be reproduced in the login screen post OOBE also: 1. Connect to a secure wifi network from the system tray and enter an incorrect password. The 'Join WiFi network' dialog should appear as well as a notification. 2. While the 'Join WiFi network' dialog is still visible, click on the notification. Observe: The network settings dialog appears over tje 'Join WiFi network' dialog but does not have focus and can not be interactive with, moved, or closed. As a short term workaround for 64 we can disable opening the dialog from the notificaiton on the login screen.
,
Dec 13 2017
Short term workaround here: https://chromium-review.googlesource.com/c/chromium/src/+/825626
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b6bbb0348e4ec1ccbef8993a5d54bdc62a6f888 commit 4b6bbb0348e4ec1ccbef8993a5d54bdc62a6f888 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Dec 14 00:39:31 2017 NetworkConfigView: Prevent SystemWebDialogDelegate from opening There are a few cases where a user might open a SystemWebDialogDelegate while NetworkConfigView is open. NetworkConfigView uses SystemTrayClient::CreateUnownedDialogWidget which does not interact well with SystemWebDialogDelegate (see issue). Since NetworkConfigView will soon be deprecated, the simplest short term fix is to not show any SystemWebDialogDelegate instance while NetworkConfigView is shown. This will not seem to strange to a user since NetworkConfigView is a modal dialog. Bug: 791955 Change-Id: Ibe37ff737df69d5d02670c435124e2837ddb0bab Reviewed-on: https://chromium-review.googlesource.com/825626 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523955} [modify] https://crrev.com/4b6bbb0348e4ec1ccbef8993a5d54bdc62a6f888/chrome/browser/chromeos/options/network_config_view.cc [modify] https://crrev.com/4b6bbb0348e4ec1ccbef8993a5d54bdc62a6f888/chrome/browser/chromeos/options/network_config_view.h [modify] https://crrev.com/4b6bbb0348e4ec1ccbef8993a5d54bdc62a6f888/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.cc
,
Dec 14 2017
I filed issue 794776 to track the underlying issue. Marking this specific issue as fixed and requesting a merge to 64.
,
Dec 14 2017
Approving merge to M64 Chrome OS.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8eacfec2f0599eddb7dabf105b007027ea13d14e commit 8eacfec2f0599eddb7dabf105b007027ea13d14e Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Dec 14 17:52:14 2017 NetworkConfigView: Prevent SystemWebDialogDelegate from opening There are a few cases where a user might open a SystemWebDialogDelegate while NetworkConfigView is open. NetworkConfigView uses SystemTrayClient::CreateUnownedDialogWidget which does not interact well with SystemWebDialogDelegate (see issue). Since NetworkConfigView will soon be deprecated, the simplest short term fix is to not show any SystemWebDialogDelegate instance while NetworkConfigView is shown. This will not seem to strange to a user since NetworkConfigView is a modal dialog. Bug: 791955 Change-Id: Ibe37ff737df69d5d02670c435124e2837ddb0bab Reviewed-on: https://chromium-review.googlesource.com/825626 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523955}(cherry picked from commit 4b6bbb0348e4ec1ccbef8993a5d54bdc62a6f888) Reviewed-on: https://chromium-review.googlesource.com/826329 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#230} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/8eacfec2f0599eddb7dabf105b007027ea13d14e/chrome/browser/chromeos/options/network_config_view.cc [modify] https://crrev.com/8eacfec2f0599eddb7dabf105b007027ea13d14e/chrome/browser/chromeos/options/network_config_view.h [modify] https://crrev.com/8eacfec2f0599eddb7dabf105b007027ea13d14e/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbleicher@google.com
, Dec 7 2017