[Dice] Reset the DiceTabHelper when reusing a signin tab |
||||||
Issue descriptionThe signin UI is sometimes shown in the current tab. If the current tab is already a signin tab, a DCHECK triggers: [44657:44657:1205/111828.501745:FATAL:dice_tab_helper.cc(29)] Check failed: signin_metrics::AccessPoint::ACCESS_POINT_UNKNOWN == signin_access_point_ (17 vs. 10) #0 0x7fb71400db9d base::debug::StackTrace::StackTrace() #1 0x7fb71400bfcc base::debug::StackTrace::StackTrace() #2 0x7fb714093baa logging::LogMessage::~LogMessage() #3 0x5620da96db20 DiceTabHelper::SetSigninAccessPoint() #4 0x5620ddfa1839 SigninViewController::ShowDiceSigninTab() #5 0x5620ddfa1348 SigninViewController::ShowSignin() #6 0x5620de17cdef ProfileChooserView::ShowViewFromMode() #7 0x5620de17fa03 ProfileChooserView::ButtonPressed() The fix would be to re-create the DiceTabHelper in that case, to reset the process to a clean state.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/424868d0420a5a421d8a2919eebd6f23a99d45c2 commit 424868d0420a5a421d8a2919eebd6f23a99d45c2 Author: David Roger <droger@chromium.org> Date: Thu Dec 07 10:56:29 2017 [signin] Reset DiceTabHelper to initial state when reusing signin tab Bug: 791948 Change-Id: Ie8f9c43ace98082e86d1bfbe01bc3ffe58a01fd6 Reviewed-on: https://chromium-review.googlesource.com/808979 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#522397} [modify] https://crrev.com/424868d0420a5a421d8a2919eebd6f23a99d45c2/chrome/browser/signin/dice_tab_helper.cc [modify] https://crrev.com/424868d0420a5a421d8a2919eebd6f23a99d45c2/chrome/browser/signin/dice_tab_helper.h [add] https://crrev.com/424868d0420a5a421d8a2919eebd6f23a99d45c2/chrome/browser/signin/dice_tab_helper_unittest.cc [modify] https://crrev.com/424868d0420a5a421d8a2919eebd6f23a99d45c2/chrome/browser/ui/signin_view_controller.cc [modify] https://crrev.com/424868d0420a5a421d8a2919eebd6f23a99d45c2/chrome/test/BUILD.gn
,
Dec 7 2017
,
Dec 8 2017
,
Dec 8 2017
,
Dec 9 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b95dead1d4300f3af489dbbb553ad4375195ff10 commit b95dead1d4300f3af489dbbb553ad4375195ff10 Author: David Roger <droger@chromium.org> Date: Mon Dec 11 10:37:49 2017 [signin] Reset DiceTabHelper to initial state when reusing signin tab TBR=droger@chromium.org (cherry picked from commit 424868d0420a5a421d8a2919eebd6f23a99d45c2) Bug: 791948 Change-Id: Ie8f9c43ace98082e86d1bfbe01bc3ffe58a01fd6 Reviewed-on: https://chromium-review.googlesource.com/808979 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522397} Reviewed-on: https://chromium-review.googlesource.com/817438 Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#123} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/b95dead1d4300f3af489dbbb553ad4375195ff10/chrome/browser/signin/dice_tab_helper.cc [modify] https://crrev.com/b95dead1d4300f3af489dbbb553ad4375195ff10/chrome/browser/signin/dice_tab_helper.h [add] https://crrev.com/b95dead1d4300f3af489dbbb553ad4375195ff10/chrome/browser/signin/dice_tab_helper_unittest.cc [modify] https://crrev.com/b95dead1d4300f3af489dbbb553ad4375195ff10/chrome/browser/ui/signin_view_controller.cc [modify] https://crrev.com/b95dead1d4300f3af489dbbb553ad4375195ff10/chrome/test/BUILD.gn |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by droger@chromium.org
, Dec 5 2017