New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791945 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ios_chrome_reading_list_egtests (iPad 5th Gen iOS 11.0) on iOS-11.0 failing

Project Member Reported by sdefresne@chromium.org, Dec 5 2017

Issue description

Test failing:

ReadingListTestCase/testSavingToReadingListAndLoadBadNetwork
ReadingListTestCase/testSavingToReadingListAndLoadNoNetwork
ReadingListTestCase/testSavingToReadingListAndLoadNormal
ReadingListTestCase/testSavingToReadingListAndLoadDistilled
 
Owner: olivierrobin@chromium.org
Status: Started (was: Untriaged)
Thanks.
I will take a look.
Components: UI>Browser>ReaderMode
Issue is that device is in landscape.
I don't know if this is supposed to work.
Cc: baxley@chromium.org rohitrao@chromium.org
+baxley to weigh in

I'd like all of our tests to pass in portrait and landscape.  Some tests will be specific to a single orientation, and that's ok, but the majority should be able to run in either orientation.

Do you have a sense for why the tests are failing in landscape?  I can take a look and try to fix them.
For RL tests, it is because the test is looking for some entries and does not find them.
I have a fix in CQ
I think there are two bugs here on the test/infra side.
1. Our tests should pass in landscape and portrait, as rohitrao@ said, but I think we should have our bots running this. (crbug.com/717548)
2. Our devices (and simulators), should be locked in the mode we want to run them in. (crbug.com/792047)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f153d7a537920dbcea5ea006005499d2eb87cbf1

commit f153d7a537920dbcea5ea006005499d2eb87cbf1
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Dec 05 16:20:00 2017

Fix Reading List EG tests in landscape mode.

In landscape, some entries are not visible and tests fail.
Allow to scroll to find them.

Bug:  791945 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6119ff89528a67a42501988ccd4db19e457d8fe7
Reviewed-on: https://chromium-review.googlesource.com/808785
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521710}
[modify] https://crrev.com/f153d7a537920dbcea5ea006005499d2eb87cbf1/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
[modify] https://crrev.com/f153d7a537920dbcea5ea006005499d2eb87cbf1/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/f153d7a537920dbcea5ea006005499d2eb87cbf1/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

Status: Fixed (was: Started)

Sign in to add a comment