New issue
Advanced search Search tips

Issue 791941 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

color-profile-* webkit_layout_test failing on Mac

Project Member Reported by markusheintz@chromium.org, Dec 5 2017

Issue description

The following webkit_layout_tests are constantly failing on mac

virtual/gpu-rasterization/images/color-profile-clip.html
virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb.html
virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d153265e06e7dd630c1e657bed1c9dd1f5a2ab6e

commit d153265e06e7dd630c1e657bed1c9dd1f5a2ab6e
Author: Markus Heintz <markusheintz@chromium.org>
Date: Tue Dec 05 10:37:11 2017

Adding failure expectation for failing tests:
 - virtual/gpu-rasterization/images/color-profile-clip.html
 - virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb.html
 - virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb.html

BUG=791941
NOTRY=true

Change-Id: Id70d34e000a38280738b7937d108c082ad8d56ab
Reviewed-on: https://chromium-review.googlesource.com/807932
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521655}
[modify] https://crrev.com/d153265e06e7dd630c1e657bed1c9dd1f5a2ab6e/third_party/WebKit/LayoutTests/TestExpectations

On Mac10.10 Tests the tests started failing in build 26745

https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/26745

With 12 CL this may be the build with least number of cls compared to the other builders.
Components: Internals>GPU
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)
->ccameron@ for triage.

I looked at one of the results from a layout-test failure [1], and the color-profile-clip-actual.png and -expected.png looks pretty close, but the -diff.png shows a fairly large difference, from what I can tell.

[1] https://storage.googleapis.com/chromium-layout-test-archives/Mac10_10_Tests/27884/layout-test-results.zip
Cc: chrishtr@chromium.org
To look at the attached results, the following tests
  virtual/gpu-rasterization/images/color-profile-clip.html
  virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb.html
  virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb.html
Just need to be rebaselined. Is there a reason why these were not just rebaselined?

Note that this is not color-profile-*, but a much smaller subset. In particular, color-profile-reflection.html is broken in the attached results (likely chrishtr's r521586... if that is an issue...).

I can rebaseline these.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f73246ba7034539dbda70502ec21b53b06cd68b3

commit f73246ba7034539dbda70502ec21b53b06cd68b3
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Jun 06 16:56:27 2018

Re-enable some disabled MacOS Layout Tests

Now that synchronization issues have been fixed on MacOS,
most previously disabled layout tests can be re-enabled.

TBR=kbr@chromium.org
Bug: chromium:726075   chromium:646528   chromium:845267  chromium:614910  chromium:845266  chromium:791941  chromium:847094   chromium:849256 

Change-Id: Ifa59c2594c429a94643ea9f19b2e08e974cc6c53
Reviewed-on: https://chromium-review.googlesource.com/1088197
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564927}
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-border-image-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/pixel-crack-image-background-webkit-transform-scale-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[delete] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-clip-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-profile-clip-expected.png

Cc: ccameron@chromium.org
 Issue 849256  has been merged into this issue.
 Issue 774873  has been merged into this issue.

Sign in to add a comment