New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 791929 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unable to open 'Office Online' Extension.

Reported by shruti.j...@etouch.net, Dec 5 2017

Issue description

Chrome Version: 65.0.3285.0 (Official Build) 2743a763a7e0772fef48cf852925f32b50ac04aa-refs/heads/master@{#521571} 64-bit

OS: Win(7,8,10), Mac(10.12.6,10.13.2) and Linux(14.04 LTS).

Test-URL:https://chrome.google.com/webstore/detail/office-online/ndjpnladcallmjemlbaebfadecfhkepb/related?hl=en

Steps to reproduce:
1.Launch chrome and Navigate to above URL.
2.Double click on Extension in omnibox and observe.
3.Navigate to chrome://extensions and observe error message as  'This extension may have been corrupted.''

Actual Result:Unable to open  'Office Online' Extension.

Expected Result:'Office Online' Extension should launch successfully.

This is regression issue broken in ‘M-64’ and below per-revision bisect result

Using the per-revision bisect providing the bisect results,
Good Build: 64.0.3246.0(Revision:510624).
Bad Build: 64.0.3247.0(Revision:510691).


You are probably looking for a change made after 510626 (known good), but no lat
er than 510627 (first known bad).

CHANGE LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/22e91af1f8dd2b6564506bbe7a
0d1d93e506afdf..cd057bb90c0216eed6b8625c73ed00e442038c58

Suspect: https://chromium.googlesource.com/chromium/src/+/cd057bb90c0216eed6b8625c73ed00e442038c58

@proberge: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
 
Actual.mp4
1.0 MB View Download
Expected.mp4
932 KB View Download
Hello,

Thanks for the very detailed bug report. I have a clarifying question:

In the steps to reproduce, you mention navigating to an extension's store page. Should I be installing the extension from the store? Or was the extension already installed on the system?

Thanks!


With respect to comment#1 
Sorry for the confusion 
I installed the extension from web store 
And in step 3 I am giving you the explaination what error message it is giving .
I installed it from web store 
The extension was not already installed .
Thank you 
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Cc: jamh...@microsoft.com
Hi Shruti. I was able to reproduce the issue and am investigating.

++jamhuan@microsoft.com who recently offered to help debug the issue on https://chrome.google.com/webstore/detail/office-online/ndjpnladcallmjemlbaebfadecfhkepb/reviews?hl=en
Cc: rdevlin....@chromium.org
It looks like the extension tries to open an empty file when the button is pressed (line 9 of app.js?). The content verifier tries to match that empty file against a known file in the extension and fails. Since the file is thought to exist by base::PathExists, the content verifier marks the extension as corrupted.

@jamhuan if you see user feedback about the extension being corrupted, it's likely coming from users on Chrome Dev or Beta. I'll fix it and try to merge it so it doesn't impact any of your users on the Stable channel.
Labels: -M-65 M-64
This should block M64.
Labels: M-63
Note: this was merge into M63 in https://chromium-review.googlesource.com/c/chromium/src/+/736079. We should either revert the merge or merge the fix into M63.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6521b2fc34425253732ee0e02e78fbf1ce5d0c13

commit 6521b2fc34425253732ee0e02e78fbf1ce5d0c13
Author: proberge <proberge@chromium.org>
Date: Tue Dec 05 19:19:26 2017

Extension content verifier: ignore empty relative paths

Some extensions make a request to "/" which confuses the extension
content verifier and causes it to mark the extension as corrupted.

Bug:  791929 
Change-Id: Id594bd714048d33ddcf88fa86b26ce0a7696503c
Reviewed-on: https://chromium-review.googlesource.com/809225
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521777}
[modify] https://crrev.com/6521b2fc34425253732ee0e02e78fbf1ce5d0c13/extensions/browser/content_hash_reader.cc
[modify] https://crrev.com/6521b2fc34425253732ee0e02e78fbf1ce5d0c13/extensions/browser/content_verify_job_unittest.cc

Cc: gov...@chromium.org
Labels: -M-63 Merge-Request-64
After discussion with the Chrome TPMs, we decided to revert https://chromium-review.googlesource.com/c/chromium/src/+/736079 from M63. This was done in https://chromium-review.googlesource.com/c/chromium/src/+/809564, hence I'm removing the M-63 release block from this issue.

Requesting a merge into M64 for the fix-forwards submitted in #8. 


As @veranika pointed out, a better long term solution would likely involve ignoring subfolders as well. 

An extension shouldn't corrupt itself just for making a request to one of its existing folders. 
Labels: OS-Chrome
Able to reproduce the issue on Chrome64.0.3282.7/CrOS 10176.4.0 - Peppy
Cc: gkihumba@chromium.org
Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Labels: TE-Verified-M63 TE-Verified-63.0.3239.84
Note: Retested the above issue on Beta# 63.0.3239.84 on Win(7,8,10),Mac OS X(10.12.6,10.13.1),Linux(14.04 LTS) and fix is working as intended.
Kindly refer the attached screen cast.
Kindly refer the attached screen cast
Thank you.
Verified.mp4
842 KB View Download
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 6 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76ed74ef6940586490cd6e68d975235a005c3016

commit 76ed74ef6940586490cd6e68d975235a005c3016
Author: proberge <proberge@chromium.org>
Date: Wed Dec 06 18:08:59 2017

Extension content verifier: ignore empty relative paths

Some extensions make a request to "/" which confuses the extension
content verifier and causes it to mark the extension as corrupted.

(Merging into M64)

Bug:  791929 
Change-Id: Id594bd714048d33ddcf88fa86b26ce0a7696503c
Reviewed-on: https://chromium-review.googlesource.com/809225
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521777}(cherry picked from commit 6521b2fc34425253732ee0e02e78fbf1ce5d0c13)
Reviewed-on: https://chromium-review.googlesource.com/811544
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#59}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/76ed74ef6940586490cd6e68d975235a005c3016/extensions/browser/content_hash_reader.cc
[modify] https://crrev.com/76ed74ef6940586490cd6e68d975235a005c3016/extensions/browser/content_verify_job_unittest.cc

Comment 17 Deleted

Marking as fixed now that the issues is reverted in M63 and that the fix is merged into M64. Created a follow-up bug for cleanup: https://bugs.chromium.org/p/chromium/issues/detail?id=792538

Sign in to add a comment