Zip Archiver: unable to open archives once failing to read file |
||||||||
Issue descriptionChrome Version: 64.0.3275.0 Steps To Reproduce: (1) Run with --enable-zip-archiver-unpacker (2) Open a zip file. See the file is mounted and the contents is displayed. (3) Remove the zip file. (4) Go to the zip volume and try to open file/directory in it. (5) (see the zip file volume diappears) (6) Try to mount a zip file. (This can be either the same one, or another ZIP file.) Expected Result: The zip file is mounted. Actual Result: The zip file is not mounted. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) - Always. What is the impact to the user, and is there a workaround? If so, what is it? - The user need to sign out once to be able to open zip files again.
,
Dec 6 2017
,
Dec 6 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0d57ac27692ba4a1e1867f1ad41d926f08074ec commit b0d57ac27692ba4a1e1867f1ad41d926f08074ec Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Dec 06 03:47:25 2017 Zip Archiver: Return error when failed to read in a file. VolumeReaderJavaScriptStream::Seek() doesn't return error even when the file is not readable. Also the error in Read() was not handled before. This was causing infinite loop when the archive became inaccessible, such as when the archive was deleted by the user. This change adds error handling on Read(). Bug: 791924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2774e53ed25eea50e6abe62ec7c52f4237c24c25 Reviewed-on: https://chromium-review.googlesource.com/808524 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521989} [modify] https://crrev.com/b0d57ac27692ba4a1e1867f1ad41d926f08074ec/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip.cc
,
Dec 6 2017
,
Dec 11 2017
Issue 539638 has been merged into this issue.
,
Jan 2 2018
This issue is still not fixed, on M65 build (Chrome OS 10272.0.0, 65.0.3299.0). The zip archive gets unmounted only when attempted to read its file contents.
,
Jan 24 2018
Closing this bug as fixed because the original issue being "unable to open archives once failing to read file" has been resolved. Filed Issue 805266 for the remaining problem, which might not deserve a blocker for Issue 690217.
,
Jan 24 2018
Verified on M64 beta build (10176.54.0, 64.0.3282.101) as well as M65 dev build (10323.2.0, 65.0.3325.11). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yamaguchi@chromium.org
, Dec 6 2017