New issue
Advanced search Search tips

Issue 791915 link

Starred by 2 users
Status: Fixed
Owner:
drott@chromium.org
Closed: Dec 2017
Cc:
behdad@chromium.org
kojii@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 785522



Sign in to add a comment

Roll HarfBuzz to 1.7.2

Project Member Reported by drott@chromium.org, Dec 5 2017 
Roll HarfBuzz to 1.7.2 and keep an eye on performance graphs as in  issue 782220  and  issue 781794 .

This should also help with  issue 785522  as it introduces an API to set the CTfont for retrieving an hb_font directly.

If the performance regressions return, we may need to revert the set changes again [1] or come up with other remedies.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/804374
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66aaf201efada2d0a2d1f3c090ef4858dd41c392

commit 66aaf201efada2d0a2d1f3c090ef4858dd41c392
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Dec 05 14:44:55 2017

Roll HarfBuzz to 1.7.2

This includes performance fixes for hb_set. After this lands, we need to
inspect the graphs for  issue 782220  and  781794  to see if performance
regressions return. Previously, these performance regressions were fixed
by reverting to the old hb_set implementation, compare
https://chromium-review.googlesource.com/c/chromium/src/+/804374.

1.7.2 also includes an additional API that allows setting the CTFont
directly, and should help with  issue 785522 .

Bug:  791915 
Change-Id: I447c1527d81e01c01253d0c3fa5b8c8b3a5a3683
Tbr: behdad, eae, kojii
Reviewed-on: https://chromium-review.googlesource.com/807986
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521689}
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/BUILD.gn
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/NEWS
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/README.chromium
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-atomic-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-blob.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-buffer-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-buffer.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-common.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-coretext.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-coretext.h
[add] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-debug.hh
[add] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-dsalgs.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ft.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-glib.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-graphite2.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-icu.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-object-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-open-file-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-open-type-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-cbdt-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-cmap-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-font.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-glyf-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-head-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-hmtx-table.hh
[add] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-kern-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout-gdef-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-layout.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-map-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-math-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-maxp-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-name-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-os2-table.hh
[add] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-post-macroman.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-post-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-win1256.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hangul.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-table.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-shape.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-tag.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-var-avar-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-var-fvar-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-var-hvar-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ot-var-mvar-table.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-set-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-set.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-shape-plan.cc
[add] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-string-array.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-ucdn.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-unicode-private.hh
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/hb-version.h
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/main.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/test-buffer-serialize.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/test-size-params.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/test-would-substitute.cc
[modify] https://crrev.com/66aaf201efada2d0a2d1f3c090ef4858dd41c392/third_party/harfbuzz-ng/src/test.cc

Comment 2 by ebra...@gnu.org, Dec 9 2017

Status: Fixed (was: Started)
It seems

Comment 3 by drott@chromium.org, Dec 11 2017 

Thanks, yes, but the set changes still had to be reverted, compare
https://chromium-review.googlesource.com/c/chromium/src/+/816795
►

Sign in to add a comment