Navigation simulator in unit tests depends on base::Time
Reported by
bpie...@opera.com,
Dec 5 2017
|
|||
Issue descriptionOS: (Win) Currently item_sequence_number and document_sequence_number (set in NavigationSimulator::Commit) depends on base::Time for example in OverscrollNavigationOverlay unit tests and in low resolution timer cases it leads to tests failure. params.item_sequence_number = base::Time::Now().ToDoubleT() * 1000000; params.document_sequence_number = params.item_sequence_number + 1; As discussed in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/yCVsKLmGtfM We should change it to simple counter.
,
Dec 5 2017
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cb48b3063ee8665161fd9126ba8cf8418e3510d commit 3cb48b3063ee8665161fd9126ba8cf8418e3510d Author: Bartosz Piekny <bpiekny@opera.com> Date: Wed Mar 07 08:46:36 2018 Remove time dependency from NavigationSimulator This commit solves issues related to low resolution timers in content_unittests. Bug: 791910 Change-Id: If572f967034354ab3d1261c4a576736bc7ba9ac5 Reviewed-on: https://chromium-review.googlesource.com/808586 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Bartosz Piękny <bpiekny@opera.com> Cr-Commit-Position: refs/heads/master@{#541386} [modify] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/content/public/test/navigation_simulator.cc
,
Mar 7 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bpie...@opera.com
, Dec 5 2017