Zip Archiver: notification close callback added every time zipping files |
||||||
Issue descriptionChrome Version: 64.0.3275.0 (1) Run with --enable-zip-archiver-packer (2) Compress files by "Zip selection" context menu. (3) Open Inspector of Zip Archiver. (4) Set breakpoint to this line. https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/zip_archiver/js/app.js?type=cs&q=chrome.notifications.onClosed.addListener+file:zip_archiver&sq=package:chromium&l=821 (5) Try to compress files by "Zip selection". The line is executed multiple times. (1 time for the first time, 2 times for the second times, ...) This bug is visible to users by itself.
,
Feb 28 2018
,
Feb 28 2018
,
Mar 9 2018
Changing sthe status to Available, because this is not a blocker of Zip Archiver, but an independent cleanup task.
"This line" in (4) means this line:
chrome.notifications.onClosed.addListener(function() {
progressNotificationCreated = false; // <<< THIS LINE
});
,
Apr 5 2018
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4c7562995b905679f9d912ea75d6788e0071954 commit c4c7562995b905679f9d912ea75d6788e0071954 Author: Anand K. Mistry <amistry@chromium.org> Date: Tue Nov 06 00:38:26 2018 Deregister notification listeners when packing is done. Deregistering the handlers avoids them being called once the packing operation is done, and an unrelated future pack operation is in progress. It also frees up a bit of memory. BUG= 791895 Change-Id: I52b8382d18b95637c868c1cdb91fed4b0f6fd276 Reviewed-on: https://chromium-review.googlesource.com/c/1317208 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605540} [modify] https://crrev.com/c4c7562995b905679f9d912ea75d6788e0071954/chrome/browser/resources/chromeos/zip_archiver/js/app.js
,
Nov 6
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sashab@chromium.org
, Feb 22 2018