Avoid unnecessary uprevs in platform2 |
|||||||
Issue descriptionWhen we make a change to one of the packages in platform2, it triggers uprevs of all platform2 packages. In fact, 73% of recent CQ runs had to uprev and build 90 platform2 packages, even for a single platform2 change; see the example CQ run below: https://uberchromegw.corp.google.com/i/chromeos/builders/caroline-paladin/builds/1970 This is making our builds unnecessarily slower. So I propose introducing subtree support in cros-workon ebuilds. The idea is to introduce a new configuration variable, CROS_WORKON_SUBTREE, to declare the paths of subtrees the ebuild cares -- for example, in the case of chromeos-base/chromeos-login: CROS_WORKON_LOCALNAME="platform2" CROS_WORKON_PROJECT="chromiumos/platform2" CROS_WORKON_SUBTREE="login_manager chromeos-config libcontainer common-mk" This declaration will be read in cros_mark_as_stable script, and changes outside of declared subtrees are ignored on deciding uprev. Also, cros-workon.eclass will be updated to set up Portage sandbox to forbid access to files outside of declared subtrees. Please see this short design doc for details: https://docs.google.com/document/d/1_DZDsAvu0_H29pluG7OvGKQAdCoZWpVivT2Xjo6TP-M/edit
,
Dec 5 2017
It's mentioned in the design doc: We already have CROS_WORKON_SUBDIRS_TO_REV, a configuration variable to instruct cros_mark_as_stable to ignore changes outside of specified directories. However it has several problems: - It does not support multi-project configurations. - It is difficult to extend it to support multi-project configurations (because it's already an array). - It does not forbid access to other files on build. For those reasons, it is more preferable to introduce a new variable and migrate use of CROS_WORKON_SUBDIRS_TO_REV to the new one.
,
Dec 5 2017
Also, proposed CROS_WORKON_SUBTREE affects the way to compute CROS_WORKON_TREE (git tree hashes of source files). This is safer than CROS_WORKON_SUBDIRS_TO_REV just ignoring changes outside of declared subtrees.
,
Dec 5 2017
for the majority of platform2 projects, the lack of multi-project support is irrelevant -- it's all in one platform2 repo. there's no reason you couldn't enable it now and have it work for most packages. yes, you'd have to be careful about file usage outside of the immediate subdir, but projects should already be doing that ... we don't really want projects reading files directly outside of common-mk/ now, so if you're aware of those, we should be filing independent bugs.
,
Dec 5 2017
> for the majority of platform2 projects, the lack of multi-project support is irrelevant -- it's all in one platform2 repo. there's no reason you couldn't enable it now and have it work for most packages. Yea, it is possible that we first use CROS_WORKON_SUBDIRS_TO_REV for single-project packages. However please note that: - SUBDIRS_TO_REV has problems I mentioned in #c3. - There are 20 multi-project platform2 packages, which are not negligible. > yes, you'd have to be careful about file usage outside of the immediate subdir, but projects should already be doing that ... we don't really want projects reading files directly outside of common-mk/ now, so if you're aware of those, we should be filing independent bugs. Such packages I'm aware of at this moment are: - chromeos-base/attestation: depends on chaps/ - chromeos-base/chromeos-login: depends on chromeos-config/, libcontainer/ - chromeos-base/cryptohome: depends on secure_erase_file - chromeos-base/lorgnette: depends on metrics/ - chromeos-base/p2p: depends on metrics/ - chromeos-base/permission_broker: depends on container_utils/ - chromeos-base/power_manager: depends on chromeos-config/, metrics/ - chromeos-base/run_oci: depends on libcontainer/ I'm not very sure if they are easy to fix.
,
Dec 5 2017
i count 16 ebuilds, and we're actively working on moving packages back into platform2. i've got 3 i'll probably do this week (tpm), and then 3 more after that (shill). firewalld is in progress of being merged into permission broker. we might do a few more merges back from aosp too, but the few left are tbd. so we're talking about 9 multi-platform2 ebuilds vs ~75 single-repo platform2 ebuilds. i'm not against figuring out how to improve things as CROS_WORKON_SUBDIRS_TO_REV is indeed limited. i just think the metrics you're using to justify the work are a bit flawed, and the original bug/reason you've filed here can already be significantly mitigated right now w/out any tooling work. i don't know what you mean by "depends on metrics/". lorgnette for example is using a system include & link of the metrics package and doesn't have any gyp references to the dir. that looks correct to me.
,
Dec 5 2017
I wrote in #c5 that: > Yea, it is possible that we first use CROS_WORKON_SUBDIRS_TO_REV for single-project packages. However, without proper automated checks, it is difficult to write correct CROS_WORKON_SUBDIRS_TO_REV. So I'd like to avoid increasing usage of it even if it will benefit us early.
,
Dec 5 2017
I see, it's good to know you're working to remove multi-project usage. It is of course simpler to make them single-project. Also it's good to hear you're fine with this proposal. I'll proceed with it. Existing CROS_WORKON_SUBDIRS_TO_REV can be used, yes, but as I wrote in #c7, it's difficult for me to declare it correctly without proper checking. So let me introduce the new variable.
,
Dec 5 2017
> i don't know what you mean by "depends on metrics/". lorgnette for example is using a system include & link of the metrics package and doesn't have any gyp references to the dir. that looks correct to me. I just meant platform2/lorgnette/manager.h has #include <metrics/metrics_library.h> so building it needs access to platform2/metrics directory.
,
Dec 5 2017
,
Dec 8 2017
Sorry for no update, I've been on vacation for 1.5 days. After thinking for a while, I changed my mind and decided to go first with CROS_WORKON_SUBDIRS_TO_REV for single-project packages to gain performance improvement earlier, as vapier@ suggested. I'm soon sending following two CLs for this: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/816482 https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/816679 There are still some packages where we can't use CROS_WORKON_SUBDIRS_TO_REV, and more importantly, we can't catch misconfigurations in CROS_WORKON_SUBDIRS_TO_REV, so I'll work on introducing new mechanism in parallel. It's really helpful if you could take a look at the design document mentioned above for early feedback on the design. Thanks!
,
Dec 8 2017
+pmalani who worked on this and its interaction with the autotest eclasses. I agree that CROS_WORKON_SUBDIRS_TO_REV is a bit of a risky hack, but it can be made to work. Getting the performance gain now by using it, and then porting to a smarter rev logic as nya@ suggests sgtm.
,
Dec 8 2017
,
Dec 8 2017
Yeah, crbug.com/655884 has the relevant commits. That was used specifically for autotest packages, but for platform2 , it is very easy to see the same logic being repurposed for use here. Specifically, the function which extracted the relevant subdirs to look for was in this patch: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/439684 It used the IUSE_TESTS value to reason about the relevant subdirs, but that can be generalized. The logic to check for commits to the subdirs is can also be re-used.
,
Dec 11 2017
Thanks akeshet, pmalani for the pointer! I'm hesitant to add package-specific logic to portage_util.py because requires us to edit the Python code every time we find new requirements. I'm glad if you could see the design doc https://docs.google.com/document/d/1_DZDsAvu0_H29pluG7OvGKQAdCoZWpVivT2Xjo6TP-M/edit for my generic-purpose proposal.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0478c99d27c3cdbd6b7b810a093f0c0c21bfb825 commit 0478c99d27c3cdbd6b7b810a093f0c0c21bfb825 Author: Shuhei Takahashi <nya@chromium.org> Date: Mon Dec 11 11:11:04 2017 imageloader: Fix build breakage on certain cases. tl;dr references to "../../platform2" do not work in some cases; they should be replaced with just ".." References to ../../platform2 work only when cros-workon out-of-tree build is actually used. While imageloader's ebuilds set CROS_WORKON_OUTOFTREE_BUILD=1, it does not take effect if the local checkout is different from CROS_WORKON_COMMIT recorded in the ebuild. In such cases, platform2 directory is copied to $S = $WORKDIR/$PN, so the directory name will be $PN, not platform2. This issue seemed to be not very visible because we've been uprev'ing imageloader ebuild every time when platform2 gets a change -- see crbug.com/791888. But once we fix the issue, it will be usual that CROS_WORKON_COMMIT differs from local checkout state, so this bug first. Also, format is fixed to pass presubmit checks. BUG=chromium:791888 TEST=emerge-samus --nodeps chromeos-base/imageloader Change-Id: I176d47a0df374a47a44bc9d16b9326ced2d90743 Reviewed-on: https://chromium-review.googlesource.com/816482 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0478c99d27c3cdbd6b7b810a093f0c0c21bfb825/imageloader/imageloader-client.gyp [modify] https://crrev.com/0478c99d27c3cdbd6b7b810a093f0c0c21bfb825/imageloader/imageloader.gyp
,
Dec 28 2017
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aed98024ff443c0f5172c0a99bed08657f9bcecf commit aed98024ff443c0f5172c0a99bed08657f9bcecf Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Jan 09 09:04:45 2018 shill-test-scripts: Drop reference to platform2. It can be built without platform2 checkout. BUG=chromium:791888 TEST=emerge-samus --nodeps chromeos-base/shill-test-scripts Change-Id: I559296a1a9cc4fe322d83fd12d5251e08eaf6868 Reviewed-on: https://chromium-review.googlesource.com/845469 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/aed98024ff443c0f5172c0a99bed08657f9bcecf/chromeos-base/shill-test-scripts/shill-test-scripts-9999.ebuild
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/200910035c0a6be9418bcef3af6c2abbbf4a329f commit 200910035c0a6be9418bcef3af6c2abbbf4a329f Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Jan 09 11:33:20 2018 cros-workon: Require CROS_WORKON_DESTDIR to be under S. This is a preparation to introduce CROS_WORKON_SUBTREE. BUG=chromium:791888 TEST=emerge-$BOARD --nodeps chromeos-base/chromeos-ec Change-Id: I02a2dc4a59e9d894b1ae89ae0b4ade32b9801c43 Reviewed-on: https://chromium-review.googlesource.com/807598 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/200910035c0a6be9418bcef3af6c2abbbf4a329f/eclass/cros-workon.eclass [modify] https://crrev.com/200910035c0a6be9418bcef3af6c2abbbf4a329f/chromeos-base/chromeos-ec/chromeos-ec-9999.ebuild
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f9d4dc85aa047edb865c3aa38ec34495a34e0827 commit f9d4dc85aa047edb865c3aa38ec34495a34e0827 Author: Shuhei Takahashi <nya@chromium.org> Date: Mon Jan 29 07:30:59 2018 autotest: Ignore manifest-versions. BUG=chromium:791888 TEST=manifest-versions is ignored. Change-Id: I5eecf1aaa337804059ca755fd697e63ca0e6c63c Reviewed-on: https://chromium-review.googlesource.com/888379 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f9d4dc85aa047edb865c3aa38ec34495a34e0827/.gitignore
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ea13ddceecf743dd3af966a1d13ca3e99d8d80bd commit ea13ddceecf743dd3af966a1d13ca3e99d8d80bd Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Jan 30 11:56:27 2018 cros-workon: Honor .gitignore on copying files. On copying files locally, pass --filter to rsync to follow rules in .gitignore. This will eliminate all needs of CROS_WORKON_SUBDIR_BLACKLIST, so the variable is also deleted. CQ-DEPEND=CL:888379 BUG=chromium:791888 TEST=ls third_party/autotest/files/site-packages # exists TEST=cros_workon --host chromeos-base/autotest-server TEST=sudo FEATURES=keepwork emerge --nodeps chromeos-base/autotest-server TEST=ls $WORKDIR/autotest-server-9999/site-packages # not found Change-Id: Ic2c289007f8d6d6d510a8b16ff27971a2ff3bb35 Reviewed-on: https://chromium-review.googlesource.com/845474 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/ea13ddceecf743dd3af966a1d13ca3e99d8d80bd/chromeos-base/autotest-web-frontend/autotest-web-frontend-9999.ebuild [modify] https://crrev.com/ea13ddceecf743dd3af966a1d13ca3e99d8d80bd/chromeos-base/autotest/autotest-9999.ebuild [modify] https://crrev.com/ea13ddceecf743dd3af966a1d13ca3e99d8d80bd/eclass/cros-workon.eclass [modify] https://crrev.com/ea13ddceecf743dd3af966a1d13ca3e99d8d80bd/chromeos-base/autotest-server/autotest-server-9999.ebuild [modify] https://crrev.com/ea13ddceecf743dd3af966a1d13ca3e99d8d80bd/chromeos-base/cros-devutils/cros-devutils-9999.ebuild
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/793ae39e4fd76f54a6b3edb8168dc2a221fbef67 commit 793ae39e4fd76f54a6b3edb8168dc2a221fbef67 Author: Shuhei Takahashi <nya@chromium.org> Date: Wed Feb 07 23:04:12 2018 cros-workon: Introduce CROS_WORKON_SUBTREE. CROS_WORKON_SUBTREE allows to declare subtrees in source checkouts needed to build the package. It will also be used in cros_mark_as_stable to avoid unnecessary uprevs. CQ-DEPEND=CL:807598 BUG=chromium:791888 TEST=precq Change-Id: I902024525fc7dd97986509a005e2aafd7859387b Reviewed-on: https://chromium-review.googlesource.com/807599 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/793ae39e4fd76f54a6b3edb8168dc2a221fbef67/eclass/cros-workon.eclass
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a54aef537514714f34ce269f75de5e632cd575f9 commit a54aef537514714f34ce269f75de5e632cd575f9 Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Feb 08 09:24:35 2018 cros_mark_as_stable: Consider CROS_WORKON_SUBTREE on uprev. This change consists of two main parts to support CROS_WORKON_SUBTREE in cros_mark_as_stable. 1. Consider CROS_WORKON_SUBTREE on generating CROS_WORKON_TREE. CROS_WORKON_TREE is a list of tree hashes in source repositories. Formerly, it was always computed from repository root directories. But after this change, when CROS_WORKON_SUBTREE is specified, tree hashes will be computed from specified subdirectories instead. By setting CROS_WORKON_SUBTREE appropriately, we can avoid unnecessary uprevs because CROS_WORKON_TREE does not change by unrelated changes in different subdirectories, particularly in large shared source repositories like platform2. 2. Skip uprev if ebuilds differ only on CROS_WORKON_COMMIT line. On comparing the new candidate stable ebuild with the old stable ebuild, ignore CROS_WORKON_COMMIT line. One of the most important purposes of CROS_WORKON_COMMIT was to check identicalness of the source code and trigger uprev when the source code changed. But this purpose is now fulfilled by CROS_WORKON_TREE, so we do not need to consider it on deciding whether to uprev. This will also avoid unnecessary uprevs when changes are made in unrelated subdirectories in source repositories. Note that we still use CROS_WORKON_COMMIT for other purposes (e.g. embedding commit hash into software version numbers), so we can not delete CROS_WORKON_COMMIT. CQ-DEPEND=CL:807599 BUG=chromium:791888 TEST=cros_mark_as_stable --board=samus --all commit TEST=portage_util_unittest Change-Id: Ic48ef18cf68cc26a565a0297b7fba38c851e9613 Reviewed-on: https://chromium-review.googlesource.com/886302 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a54aef537514714f34ce269f75de5e632cd575f9/lib/portage_util_unittest.py [modify] https://crrev.com/a54aef537514714f34ce269f75de5e632cd575f9/lib/portage_util.py
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b230b717e95c894980462d54e66ae1093364fc88 commit b230b717e95c894980462d54e66ae1093364fc88 Author: Shuhei Takahashi <nya@chromium.org> Date: Fri Feb 09 07:42:03 2018 coreboot-sdk: Use CROS_WORKON_SUBTREE. CQ-DEPEND=CL:807599 BUG=chromium:791888 TEST=precq/cq Change-Id: Ic9bcba055b10036754cc0ff6fde65a5e64a49511 Reviewed-on: https://chromium-review.googlesource.com/845473 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b230b717e95c894980462d54e66ae1093364fc88/dev-embedded/coreboot-sdk/coreboot-sdk-9999.ebuild
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/70ed9c3171fde4b78d79cd1368b45eda15a0b12e commit 70ed9c3171fde4b78d79cd1368b45eda15a0b12e Author: Shuhei Takahashi <nya@chromium.org> Date: Fri Feb 09 13:24:50 2018 cros-workon: Exclude CROS_WORKON_TREE from count check. After introduction of CROS_WORKON_SUBTREE support in crrev.com/c/886302, the number of elements in CROS_WORKON_TREE does not always match with the project count. BUG=chromium:791888 TEST=Patch CL:845470 TEST=cros_mark_as_stable --board=caroline --all commit TEST=emerge-caroline --nodeps libweave # no error Change-Id: I9e5195f63e6e42be20acb33a39d6fb13d8b889ee Reviewed-on: https://chromium-review.googlesource.com/910611 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/70ed9c3171fde4b78d79cd1368b45eda15a0b12e/eclass/cros-workon.eclass
,
Feb 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3 commit e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3 Author: Shuhei Takahashi <nya@chromium.org> Date: Sat Feb 10 00:07:13 2018 platform2: Use CROS_WORKON_SUBTREE. This patch updates most of platform2 ebuilds to use CROS_WORKON_SUBTREE. List of updated packages, groups by boards used to test: amd64-generic: - chromeos-base/vm_tools coral: - chromeos-base/modemfwd daisy: - chromeos-base/cromo - chromeos-base/gobi-cromo-plugin - chromeos-base/wimax_manager eve: - chromeos-base/arc-obb-mounter - chromeos-base/arc-setup - chromeos-base/attestation - chromeos-base/authpolicy - chromeos-base/avtest_label_detect - chromeos-base/bootstat - chromeos-base/chaps - chromeos-base/chromeos-config-tools - chromeos-base/chromeos-imageburner - chromeos-base/chromeos-init - chromeos-base/chromeos-installer - chromeos-base/chromeos-login - chromeos-base/chromeos-test-init - chromeos-base/chromeos-trim - chromeos-base/container_utils - chromeos-base/crash-reporter - chromeos-base/cros-disks - chromeos-base/crosh - chromeos-base/cryptohome - chromeos-base/cryptohome-client - chromeos-base/debugd - chromeos-base/debugd-client - chromeos-base/disk_updater - chromeos-base/easy-unlock - chromeos-base/imageloader - chromeos-base/imageloader-client - chromeos-base/libbrillo - chromeos-base/libchromeos-ui - chromeos-base/libcontainer - chromeos-base/libpasswordprovider - chromeos-base/lorgnette - chromeos-base/metrics - chromeos-base/midis - chromeos-base/mist - chromeos-base/modem-utilities - chromeos-base/mount-passthrough - chromeos-base/mtpd - chromeos-base/p2p - chromeos-base/permission_broker - chromeos-base/permission_broker-client - chromeos-base/power_manager - chromeos-base/power_manager-client - chromeos-base/quipper - chromeos-base/run_oci - chromeos-base/secure-erase-file - chromeos-base/session_manager-client - chromeos-base/shill - chromeos-base/shill-client - chromeos-base/smbprovider - chromeos-base/st_flash - chromeos-base/system_api - chromeos-base/timberslide - chromeos-base/tpm_manager - chromeos-base/trunks - chromeos-base/u2fd - chromeos-base/update_engine - chromeos-base/update_engine-client - chromeos-base/userfeedback - chromeos-base/virtual-file-provider - chromeos-base/vpn-manager - dev-util/bsdiff - dev-util/puffin - sys-apps/mosys - chromeos-base/apmanager [*] - chromeos-base/arc-apk-cache [*] - chromeos-base/biod [*] - chromeos-base/goldfishd [*] - chromeos-base/ippusb_manager [*] - chromeos-base/peerd [*] - chromeos-base/smogcheck [*] - chromeos-base/touch_keyboard [*] - chromeos-base/userspace_touchpad [*] - sys-apps/fitpicker [*] gale: - chromeos-base/buffet - chromeos-base/feedback - chromeos-base/libweave - chromeos-base/webserver guado: - chromeos-base/atrusctl - sys-apps/cfm-device-monitor host: - chromeos-base/chromeos-config-host - chromeos-base/chromeos-dbus-bindings - chromeos-base/regions kevin: - chromeos-base/touch_firmware_calibration poppy: - chromeos-base/hammerd - chromeos-base/hammerd-test-utils UNTESTED (build fails even without CROS_WORKON_SUBTREE): - chromeos-base/cros_component - chromeos-base/salsa - chromeos-base/thd - chromeos-base/tpm2-simulator NOTE: Packages marked with [*] are not depended by any board as I could tell, but I could build them with emerge-$BOARD --nodeps. CQ-DEPEND=CL:807599 CQ-DEPEND=CL:910611 BUG=chromium:791888 BUG=chromium:809389 TEST=cros_mark_as_stable --board=$BOARD --all commit TEST=emerge-$BOARD --nodeps PACKAGES Change-Id: Ibb9e1fbb44004880efff44cc27364234eab04336 Reviewed-on: https://chromium-review.googlesource.com/845470 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/dev-util/bsdiff/bsdiff-4.3.1-r10.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/tpm_manager/tpm_manager-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/permission_broker/permission_broker-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/update_engine/update_engine-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/system_api/system_api-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/atrusctl/atrusctl-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-trim/chromeos-trim-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/attestation/attestation-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-imageburner/chromeos-imageburner-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/midis/midis-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/vm_tools/vm_tools-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/shill-client/shill-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/debugd/debugd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/smbprovider/smbprovider-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/u2fd/u2fd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/touch_firmware_calibration/touch_firmware_calibration-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/authpolicy/authpolicy-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/gobi-cromo-plugin/gobi-cromo-plugin-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/libbrillo/libbrillo-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/thd/thd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/modemfwd/modemfwd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/bootstat/bootstat-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/disk_updater/disk_updater-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/buffet/buffet-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-init/chromeos-init-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/timberslide/timberslide-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/cromo/cromo-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-installer/chromeos-installer-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/salsa/salsa-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/avtest_label_detect/avtest_label_detect-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/mist/mist-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/arc-apk-cache/arc-apk-cache-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/run_oci/run_oci-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/touch_keyboard/touch_keyboard-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/metrics/metrics-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-config-host/chromeos-config-host-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/cros-disks/cros-disks-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/cros_component/cros_component-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/imageloader-client/imageloader-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/p2p/p2p-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/sys-apps/cfm-device-monitor/cfm-device-monitor-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/permission_broker-client/permission_broker-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/userfeedback/userfeedback-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/cryptohome-client/cryptohome-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/vpn-manager/vpn-manager-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/secure-erase-file/secure-erase-file-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/peerd/peerd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/hammerd-test-utils/hammerd-test-utils-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/biod/biod-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/webserver/webserver-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/virtual-file-provider/virtual-file-provider-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/arc-obb-mounter/arc-obb-mounter-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/regions/regions-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/sys-apps/fitpicker/fitpicker-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/libweave/libweave-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chaps/chaps-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/cryptohome/cryptohome-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/arc-setup/arc-setup-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/apmanager/apmanager-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/shill/shill-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/lorgnette/lorgnette-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/libpasswordprovider/libpasswordprovider-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/mount-passthrough/mount-passthrough-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/update_engine-client/update_engine-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-dbus-bindings/chromeos-dbus-bindings-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/libchromeos-ui/libchromeos-ui-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-test-init/chromeos-test-init-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/libcontainer/libcontainer-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/debugd-client/debugd-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/feedback/feedback-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/modem-utilities/modem-utilities-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/quipper/quipper-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/imageloader/imageloader-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/easy-unlock/easy-unlock-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/container_utils/container_utils-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/crash-reporter/crash-reporter-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/session_manager-client/session_manager-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/goldfishd/goldfishd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/hammerd/hammerd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/tpm2-simulator/tpm2-simulator-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/sys-apps/mosys/mosys-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/power_manager/power_manager-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/power_manager-client/power_manager-client-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/dev-util/puffin/puffin-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/userspace_touchpad/userspace_touchpad-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/trunks/trunks-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/crosh/crosh-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/st_flash/st_flash-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/ippusb_manager/ippusb_manager-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/smogcheck/smogcheck-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-login/chromeos-login-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/dev-util/bsdiff/bsdiff-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/mtpd/mtpd-9999.ebuild [modify] https://crrev.com/e5b03cf4c41c0c193ed966c0ad2559f3dd3e6dc3/chromeos-base/wimax_manager/wimax_manager-9999.ebuild
,
Feb 14 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-jetstream-private/+/17e1d20a8f1163e612ae24ba680f9c5200c9c987 commit 17e1d20a8f1163e612ae24ba680f9c5200c9c987 Author: Shuhei Takahashi <nya@google.com> Date: Wed Feb 14 08:48:20 2018
,
Feb 14 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-partner-overlay/+/d69d7d152d8b5953ce294726fa19c3a41fd54b08 commit d69d7d152d8b5953ce294726fa19c3a41fd54b08 Author: Shuhei Takahashi <nya@google.com> Date: Wed Feb 14 12:07:27 2018
,
Feb 14 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/bbdff26bbd896d18a9c5214ee5a75368436fb667 commit bbdff26bbd896d18a9c5214ee5a75368436fb667 Author: Shuhei Takahashi <nya@google.com> Date: Wed Feb 14 12:07:21 2018
,
Feb 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-kahlee-private/+/37401b9a064d4cfd46440100e8fe2f90306a0ff9 commit 37401b9a064d4cfd46440100e8fe2f90306a0ff9 Author: Shuhei Takahashi <nya@google.com> Date: Thu Feb 22 07:04:39 2018
,
Feb 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-fizz-private/+/506fbab2c1a48d97c2adf51b1f1321683966cd69 commit 506fbab2c1a48d97c2adf51b1f1321683966cd69 Author: Shuhei Takahashi <nya@google.com> Date: Thu Feb 22 12:13:55 2018
,
Feb 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/192a05b7ba393fc8dde0ceec28d634a9c08f0025 commit 192a05b7ba393fc8dde0ceec28d634a9c08f0025 Author: Shuhei Takahashi <nya@google.com> Date: Thu Feb 22 12:13:51 2018
,
Feb 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-coral-private/+/9a0c382620fff6644a5faaa824b6c00eb49d2fa2 commit 9a0c382620fff6644a5faaa824b6c00eb49d2fa2 Author: Shuhei Takahashi <nya@google.com> Date: Thu Feb 22 12:13:52 2018
,
Feb 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-grunt-private/+/6d46a2c794ce263232e5cc556c4ad9fa83df99fa commit 6d46a2c794ce263232e5cc556c4ad9fa83df99fa Author: Shuhei Takahashi <nya@google.com> Date: Thu Feb 22 12:14:01 2018
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/48ce02df7409c8b1d1c0943dcdf9b7b818367050 commit 48ce02df7409c8b1d1c0943dcdf9b7b818367050 Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Feb 22 12:13:58 2018 bluetooth: Use CROS_WORKON_SUBTREE. BUG=chromium:791888 TEST=emerge-cave --nodeps chromeos-base/bluetooth Change-Id: I3da205aafba6cb2a974a1d1a2acc8bc88c160a43 Reviewed-on: https://chromium-review.googlesource.com/923691 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/48ce02df7409c8b1d1c0943dcdf9b7b818367050/chromeos-base/bluetooth/bluetooth-9999.ebuild
,
Feb 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-rainier-private/+/8c61ec65d10d50be990d77d48cfb6d1e6b7cb8e0 commit 8c61ec65d10d50be990d77d48cfb6d1e6b7cb8e0 Author: Shuhei Takahashi <nya@google.com> Date: Thu Feb 22 12:14:00 2018
,
Feb 23 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-fizz-private/+/db1b62745fb05bf4ec22f6d65abbe8065b3628c8 commit db1b62745fb05bf4ec22f6d65abbe8065b3628c8 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Feb 23 11:36:39 2018
,
Mar 1 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-jetstream-private/+/5ddbc248845122309e51be7ac7ab4238ec420db7 commit 5ddbc248845122309e51be7ac7ab4238ec420db7 Author: Shuhei Takahashi <nya@google.com> Date: Thu Mar 01 05:30:12 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ec53f418f7a305c09efa0c4795530a25410e90bc commit ec53f418f7a305c09efa0c4795530a25410e90bc Author: Shuhei Takahashi <nya@chromium.org> Date: Mon Mar 12 12:19:36 2018 autotest: Use CROS_WORKON_SUBTREE. Use CROS_WORKON_SUBTREE instead of CROS_WORKON_SUBDIRS_TO_COPY. Also, remove a reference to client/config. The directory was removed in CL:178564. BUG=chromium:791888 TEST=build_packages --board=samus Change-Id: I638737ae4b9a7191a1d269624dba278b63f4e3da Reviewed-on: https://chromium-review.googlesource.com/845472 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/ec53f418f7a305c09efa0c4795530a25410e90bc/eclass/autotest.eclass
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4da61e9c13fc98bf89e4077c3015dd8b76773e40 commit 4da61e9c13fc98bf89e4077c3015dd8b76773e40 Author: Aviv Keshet <akeshet@chromium.org> Date: Tue Mar 13 04:07:30 2018 Revert "autotest: Use CROS_WORKON_SUBTREE." BUG=chromium:791888, chromium:821207 TEST=None This reverts commit ec53f418f7a305c09efa0c4795530a25410e90bc. Change-Id: I432d0ab848d98cd021a89f941d99619037d0a47d Reviewed-on: https://chromium-review.googlesource.com/959752 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/4da61e9c13fc98bf89e4077c3015dd8b76773e40/eclass/autotest.eclass
,
Jun 8 2018
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0fd31a5e400add305fef9647f828c506c57566bc commit 0fd31a5e400add305fef9647f828c506c57566bc Author: Shuhei Takahashi <nya@chromium.org> Date: Fri Oct 19 04:35:54 2018 coreboot-sdk: Use CROS_WORKON_SUBTREE. CQ-DEPEND=CL:807599 BUG=chromium:791888 TEST=precq/cq Change-Id: Ic9bcba055b10036754cc0ff6fde65a5e64a49511 Reviewed-on: https://chromium-review.googlesource.com/845473 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit b230b717e95c894980462d54e66ae1093364fc88) Reviewed-on: https://chromium-review.googlesource.com/c/1273711 Reviewed-by: Stefan Reinauer <reinauer@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org> Tested-by: Vadim Bendebury <vbendeb@chromium.org> [modify] https://crrev.com/0fd31a5e400add305fef9647f828c506c57566bc/dev-embedded/coreboot-sdk/coreboot-sdk-9999.ebuild
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8a821badcafa1aa3dc1730d85f4def779fb354d1 commit 8a821badcafa1aa3dc1730d85f4def779fb354d1 Author: Shuhei Takahashi <nya@chromium.org> Date: Fri Dec 07 00:18:14 2018 coreboot-sdk: Use CROS_WORKON_SUBTREE. CQ-DEPEND=CL:807599 BUG=chromium:791888 TEST=precq/cq Change-Id: Ic9bcba055b10036754cc0ff6fde65a5e64a49511 Reviewed-on: https://chromium-review.googlesource.com/845473 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit b230b717e95c894980462d54e66ae1093364fc88) Reviewed-on: https://chromium-review.googlesource.com/c/1273711 Reviewed-by: Stefan Reinauer <reinauer@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org> Tested-by: Vadim Bendebury <vbendeb@chromium.org> (cherry picked from commit 0fd31a5e400add305fef9647f828c506c57566bc) Reviewed-on: https://chromium-review.googlesource.com/c/1367024 [modify] https://crrev.com/8a821badcafa1aa3dc1730d85f4def779fb354d1/dev-embedded/coreboot-sdk/coreboot-sdk-9999.ebuild |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vapier@chromium.org
, Dec 5 2017